[Bug 45493] SRPG Studio games need proper DISPATCH_PROPERTYPUTREF implementation

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=45493

--- Comment #11 from Gabriel Ivăncescu <gabrielopcode at gmail.com> ---
(In reply to Rafał Mużyło from comment #10)
> Well, I've only checked that particular commit and have yet to do any real
> tests, but the simple check of the place that consistently failed gives now
> a pass.
> 
> Though that commit looks odd...Should it really be that simple ?

Well, PUTREF is supposed to be used for references to objects, which was
already the case (jscript treats objects as references, i.e. passing them
around doesn't copy by value). According to the tests, "values" are unaffected
by PUTREF and act just like PUT.

It's possible I missed corner cases I didn't think of, of course. If you find
something different or a corner case with PUTREF, feel free to report it or
even write tests yourself if you want to. My guess is that PUTREF is probably
different in languages where objects are not necessarily treated as refs.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.