[Bug 52354] winemac.drv not functional on non metal GPUs

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52354

Tim Clem <tclem at codeweavers.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tclem at codeweavers.com

--- Comment #9 from Tim Clem <tclem at codeweavers.com> ---
Just to clarify, the original build failures were Metal related, but the
rendering problems are not. I can reproduce these issues on my 2015 MacBook
Pro, which supports Metal.

There are two distinct issues at play here, both of which do not happen in
Mojave or later.

1. As Brendan noted in the mailing list thread, calling setNeedsDisplay: on
WineContentViews doesn't trigger an updateLayer call. This is supposed to
happen if the layer has a layerContentsRedrawPolicy of
NSViewLayerContentsRedrawOnSetNeedsDisplay. We don't currently set that, so it
must somehow work without the redraw policy on later versions of macOS.
However, even with that policy set, updateLayer basically gets called once per
window on High Sierra. I can work around this by making WineContentView's
setNeedsDisplay: and setNeedsDisplayInRect: manually call the analogous methods
on its layer. That makes the window contents draw, and reliably reveals issue
#2.

2. On retina-capable screens on High Sierra, the contentsScale of
WineContentView's layer is always effectively 2, regardless of Wine's settings.
We set the initial contentsScale on the layer when we make WineContentViews,
and we return false from -layer:shouldInheritContentsScale:fromWindow: unless
retina mode is on, so this should not happen. But somehow, by the time
updateLayer is called, the contentsScale is always 2. That's not a scenario
that the code expects, so we wind up creating an incorrectly scaled image, and
we get the misalignment shown in Dean's screenshot.

While it's relatively easy to work around issue #1, issue #2 is more
persistent. The best mitigation I've come up with for that involves forcibly
rendering the layer's contents at the scale implied by Wine's retina setting
(rather than the layer's actual contentsScale). On retina displays that at
least gets the view's contents to align correctly, but the upscaling looks
horrible.

I think it makes sense to just revert the patches. I'll submit that to
wine-devel.

In the long run I'm not sure that layer-backed views are the right direction,
if only because updateLayer requires a complete redraw of the view vs.
drawRect:'s more precise dirtyRect.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.