[Bug 51665] HITMAN 2 (2018) crashes on launch in Direct3D 12 mode (needs dxgi_adapter_RegisterVideoMemoryBudgetChangeNotificationEvent() implementation)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51665

DrkShadow <winehq.10.drkshadow at spamgourmet.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |winehq.10.drkshadow at spamgou
                   |                            |rmet.com

--- Comment #2 from DrkShadow <winehq.10.drkshadow at spamgourmet.com> ---
Adding a MeToo! with additional info.

Lightroom v11 is crashing with this fixme,
fixme:dxgi:dxgi_adapter_RegisterVideoMemoryBudgetChangeNotificationEvent

At the suggestion from IRC, I modified `wine-7.1/dlls/dxgi/adapter.c` to return
S_OK instead of E_NOTIMPL for this function.

return E_NOTIMPL: Lightroom would crash after start, when I go to File | New
Catalog. The fixme above would appear.

return S_OK: Lightroom creates the new catalog and restarts to load the new
catalog. I'm able to import photos and perform edits. Everything appears to be
working appropriately.

---
Not thoroughly tested. The function is about budget change notifications, and
this S_OK return value does not implement the notifications. It's hard to know
the ramifications - memory leaks? undefined behavior? crashes/corruption on
resizing windows? Probably nothing worse than returning E_NOTIMPL, except that
the program continues instead of faults.

May or may not work for this game or others, I haven't tested with anything but
lightroom.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.