[Bug 53014] HICON leak in CopyImage causes TheBat! to crash after a while

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53014

Jacek Caban <jacek at codeweavers.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jacek at codeweavers.com

--- Comment #6 from Jacek Caban <jacek at codeweavers.com> ---
Those CopyImage calls are wrong, PE calls should not hold user lock. I think we
should fix it in class.c to make sure all those calls don't hold the lock.

BTW, the lock is nothing new, it was previously hold by user32 and is needed
when accessing user_handles.

UNICODE_STRING Length handling really uses characters in this case, see related
tests:
https://source.winehq.org/git/wine.git/blob/HEAD:/dlls/win32u/tests/win32u.c#l377
The module/res typo was fixed by Brendan recently:
https://source.winehq.org/git/wine.git/commitdiff/b88ba537ea879772dc86fc8b811523744795b22d

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.