Marcus Meissner : msi: Report the commandline that failed to start in ERR()s.

Alexandre Julliard julliard at wine.codeweavers.com
Tue Jan 3 15:21:04 CST 2006


Module: wine
Branch: refs/heads/master
Commit: 73b7900b8babb0386b7c8e0184b0a4a2ffc04a37
URL:    http://source.winehq.org/git/?p=wine.git;a=commit;h=73b7900b8babb0386b7c8e0184b0a4a2ffc04a37

Author: Marcus Meissner <marcus at jet.franken.de>
Date:   Tue Jan  3 17:35:41 2006 +0100

msi: Report the commandline that failed to start in ERR()s.

---

 dlls/msi/custom.c |   20 ++++++++++++--------
 1 files changed, 12 insertions(+), 8 deletions(-)

diff --git a/dlls/msi/custom.c b/dlls/msi/custom.c
index 1c66953..2ed4b81 100644
--- a/dlls/msi/custom.c
+++ b/dlls/msi/custom.c
@@ -548,13 +548,14 @@ static UINT HANDLE_CustomType2(MSIPACKAG
     rc = CreateProcessW(NULL, cmd, NULL, NULL, FALSE, 0, NULL,
                   c_collen, &si, &info);
 
-    msi_free(cmd);
 
     if ( !rc )
     {
-        ERR("Unable to execute command\n");
+        ERR("Unable to execute command %s\n", debugstr_w(cmd));
+        msi_free(cmd);
         return ERROR_SUCCESS;
     }
+    msi_free(cmd);
 
     prc = process_handle(package, type, info.hThread, info.hProcess, action, 
                           &finished);
@@ -609,13 +610,14 @@ static UINT HANDLE_CustomType18(MSIPACKA
     rc = CreateProcessW(NULL, cmd, NULL, NULL, FALSE, 0, NULL,
                   c_collen, &si, &info);
 
-    msi_free(cmd);
     
     if ( !rc )
     {
-        ERR("Unable to execute command\n");
+        ERR("Unable to execute command %s\n", debugstr_w(cmd));
+        msi_free(cmd);
         return ERROR_SUCCESS;
     }
+    msi_free(cmd);
 
     prc = process_handle(package, type, info.hThread, info.hProcess, action, 
                          NULL);
@@ -694,13 +696,14 @@ static UINT HANDLE_CustomType50(MSIPACKA
     rc = CreateProcessW(NULL, cmd, NULL, NULL, FALSE, 0, NULL,
                   c_collen, &si, &info);
 
-    msi_free(cmd);
     
     if ( !rc )
     {
-        ERR("Unable to execute command\n");
+        ERR("Unable to execute command %s\n", debugstr_w(cmd));
+        msi_free(cmd);
         return ERROR_SUCCESS;
     }
+    msi_free(cmd);
 
     return process_handle(package, type, info.hThread, info.hProcess, action, NULL);
 }
@@ -733,13 +736,14 @@ static UINT HANDLE_CustomType34(MSIPACKA
 
     rc = CreateProcessW(NULL, deformated, NULL, NULL, FALSE, 0, NULL,
                   c_collen, &si, &info);
-    msi_free(deformated);
 
     if ( !rc )
     {
-        ERR("Unable to execute command\n");
+        ERR("Unable to execute command %s\n", debugstr_w(deformated));
+        msi_free(deformated);
         return ERROR_SUCCESS;
     }
+    msi_free(deformated);
 
     prc = process_handle(package, type, info.hThread, info.hProcess, action,
                          NULL);




More information about the wine-cvs mailing list