Robert Shearman : kernel32: Check for the correct error return value from open.

Alexandre Julliard julliard at wine.codeweavers.com
Thu Jan 5 10:53:46 CST 2006


Module: wine
Branch: refs/heads/master
Commit: 1191249fc96d60d07cc4ba74528c0fe2b383732e
URL:    http://source.winehq.org/git/?p=wine.git;a=commit;h=1191249fc96d60d07cc4ba74528c0fe2b383732e

Author: Robert Shearman <rob at codeweavers.com>
Date:   Thu Jan  5 12:18:29 2006 +0100

kernel32: Check for the correct error return value from open.

---

 dlls/kernel/oldconfig.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/dlls/kernel/oldconfig.c b/dlls/kernel/oldconfig.c
index eb73f78..47e249f 100644
--- a/dlls/kernel/oldconfig.c
+++ b/dlls/kernel/oldconfig.c
@@ -161,12 +161,11 @@ static void create_scsi_entry( PSCSI_ADD
         int fd, dma;
         
         fd = open(lpUnixDeviceName, O_RDONLY|O_NONBLOCK);
-        if (fd)
+        if (fd != -1)
         {
             if (ioctl(fd, HDIO_GET_DMA, &dma) != -1) value = dma;
             close(fd);
-        }else
-            ERR("Can't open %s", buffer);
+        }
 #endif
         RtlCreateUnicodeStringFromAsciiz( &nameW, "DMAEnabled" );
         NtSetValueKey( portKey,&nameW, 0, REG_DWORD, (BYTE *)&value, sizeof(DWORD));




More information about the wine-cvs mailing list