appdb/include comment.php

[WineHQ]

ChangeSet ID:	26671
CVSROOT:	/opt/cvs-commit
Module name:	appdb
Changes by:	wineowner at winehq.org	2006/07/19 22:52:02

Modified files:
	include        : comment.php 

Log message:
	Chris Morgan <cmorgan at alum.wpi.edu>
	Attempt to capture the source of erroneous input to grab_comments() using error_log::logBackTrace()

Patch: http://cvs.winehq.org/patch.py?id=26671

Old revision  New revision  Changes     Path
 1.28          1.29          +10 -0      appdb/include/comment.php

Index: appdb/include/comment.php
diff -u -p appdb/include/comment.php:1.28 appdb/include/comment.php:1.29
--- appdb/include/comment.php:1.28	20 Jul 2006  3:52: 2 -0000
+++ appdb/include/comment.php	20 Jul 2006  3:52: 2 -0000
@@ -254,6 +254,16 @@ class Comment {
      */
     function grab_comments($iVersionId, $iParentId = null)
     {
+        /* TODO: remove the logging when we figure out where the */
+        /* invalid $iVersionId is coming */
+        /* if $iVersionId is invalid we should log where we came from */
+        /* so we can debug the problem */
+        if($iVersionId == "")
+        {
+            error_log::logBackTrace("logging iVersionId oddity");
+            return NULL;
+        }
+
         /* escape input so we can use query_appdb() without concern */
         $iVersionId = mysql_real_escape_string($iVersionId);
         $iParentId = mysql_real_escape_string($iParentId);