Mike McCormack : hlink: Only release an object that we successfully created .

Alexandre Julliard julliard at wine.codeweavers.com
Mon Jul 24 06:54:59 CDT 2006


Module: wine
Branch: refs/heads/master
Commit: e4025c50c7b2aa7ef51318b6aac1b9bb0392ebf6
URL:    http://source.winehq.org/git/?p=wine.git;a=commit;h=e4025c50c7b2aa7ef51318b6aac1b9bb0392ebf6

Author: Mike McCormack <mike at codeweavers.com>
Date:   Mon Jul 24 11:55:53 2006 +0900

hlink: Only release an object that we successfully created.

---

 dlls/hlink/link.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/hlink/link.c b/dlls/hlink/link.c
index e82672c..baf3b75 100644
--- a/dlls/hlink/link.c
+++ b/dlls/hlink/link.c
@@ -444,7 +444,7 @@ static HRESULT WINAPI IHlink_fnNavigate(
     if (mon)
     {
         IBindCtx *bcxt;
-        IHlinkTarget *target;
+        IHlinkTarget *target = NULL;
         HRESULT r = S_OK;
 
         CreateBindCtx(0, &bcxt);
@@ -458,12 +458,12 @@ static HRESULT WINAPI IHlink_fnNavigate(
         {
             IHlinkTarget_SetBrowseContext(target, phbc);
             IHlinkTarget_Navigate(target, grfHLNF, This->Location);
+            IHlinkTarget_Release(target);
         }
 
         RevokeBindStatusCallback(bcxt, pbsc);
 
         IBindCtx_Release(bcxt);
-        IHlinkTarget_Release(target);
         IMoniker_Release(mon);
     }
 




More information about the wine-cvs mailing list