Stefan Leichter : msi: Native DllGetVersion does not fail if the supplied buffer is bigger than required .

Alexandre Julliard julliard at wine.codeweavers.com
Fri Jul 28 07:15:39 CDT 2006


Module: wine
Branch: refs/heads/master
Commit: 055b23b125ed9e573115ad80cfed90f9fc907640
URL:    http://source.winehq.org/git/?p=wine.git;a=commit;h=055b23b125ed9e573115ad80cfed90f9fc907640

Author: Stefan Leichter <Stefan.Leichter at camline.com>
Date:   Fri Jul 28 00:26:42 2006 +0200

msi: Native DllGetVersion does not fail if the supplied buffer is bigger than required.

---

 dlls/msi/msi_main.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/msi/msi_main.c b/dlls/msi/msi_main.c
index 1cd36a0..fcb6f5d 100644
--- a/dlls/msi/msi_main.c
+++ b/dlls/msi/msi_main.c
@@ -160,13 +160,13 @@ HRESULT WINAPI DllGetVersion(DLLVERSIONI
 {
     TRACE("%p\n",pdvi);
 
-    if (pdvi->cbSize != sizeof(DLLVERSIONINFO))
+    if (pdvi->cbSize < sizeof(DLLVERSIONINFO))
         return E_INVALIDARG;
 
     pdvi->dwMajorVersion = MSI_MAJORVERSION;
     pdvi->dwMinorVersion = MSI_MINORVERSION;
     pdvi->dwBuildNumber = MSI_BUILDNUMBER;
-    pdvi->dwPlatformID = 1;
+    pdvi->dwPlatformID = DLLVER_PLATFORM_WINDOWS;
 
     return S_OK;
 }




More information about the wine-cvs mailing list