Mike McCormack : msi: Remove some unnecessary NULL checks.

Alexandre Julliard julliard at wine.codeweavers.com
Fri Jun 9 11:16:31 CDT 2006


Module: wine
Branch: refs/heads/master
Commit: ea3ab4952b65817b35e7e44f6386aeb009e48cea
URL:    http://source.winehq.org/git/?p=wine.git;a=commit;h=ea3ab4952b65817b35e7e44f6386aeb009e48cea

Author: Mike McCormack <mike at codeweavers.com>
Date:   Fri Jun  9 17:05:33 2006 +0900

msi: Remove some unnecessary NULL checks.

---

 dlls/msi/action.c |   12 ------------
 1 files changed, 0 insertions(+), 12 deletions(-)

diff --git a/dlls/msi/action.c b/dlls/msi/action.c
index bf4e2b0..5a8e1ab 100644
--- a/dlls/msi/action.c
+++ b/dlls/msi/action.c
@@ -883,12 +883,6 @@ static BOOL ACTION_HandleStandardAction(
     BOOL run = force;
     int i;
 
-    if (!package)
-    {
-        ERR("package was null!\n");
-        return FALSE;
-    }
-
     if (!run && !package->script->CurrentlyScripting)
         run = TRUE;
    
@@ -1329,9 +1323,6 @@ static UINT load_all_files(MSIPACKAGE *p
          '`','F','i','l','e','`',' ', 'O','R','D','E','R',' ','B','Y',' ',
          '`','S','e','q','u','e','n','c','e','`', 0};
 
-    if (!package)
-        return ERROR_INVALID_HANDLE;
-
     rc = MSI_DatabaseOpenViewW(package->db, Query, &view);
     if (rc != ERROR_SUCCESS)
         return ERROR_SUCCESS;
@@ -2248,9 +2239,6 @@ static UINT ACTION_WriteRegistryValues(M
         {'S','E','L','E','C','T',' ','*',' ','F','R','O','M',' ',
          '`','R','e','g','i','s','t','r','y','`',0 };
 
-    if (!package)
-        return ERROR_INVALID_HANDLE;
-
     rc = MSI_DatabaseOpenViewW(package->db, ExecSeqQuery, &view);
     if (rc != ERROR_SUCCESS)
         return ERROR_SUCCESS;




More information about the wine-cvs mailing list