Michael Stefaniuc : twain_32: Add missing HeapFree's on error patch ( found by smatch).

Alexandre Julliard julliard at wine.codeweavers.com
Tue May 9 05:56:23 CDT 2006


Module: wine
Branch: refs/heads/master
Commit: 8d7dcb65a2d7ad617a4627b988b1480930512164
URL:    http://source.winehq.org/git/?p=wine.git;a=commit;h=8d7dcb65a2d7ad617a4627b988b1480930512164

Author: Michael Stefaniuc <mstefani at redhat.de>
Date:   Tue May  9 00:51:58 2006 +0200

twain_32: Add missing HeapFree's on error patch (found by smatch).

---

 dlls/twain_32/dsm_ctrl.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/dlls/twain_32/dsm_ctrl.c b/dlls/twain_32/dsm_ctrl.c
index 75d5c64..53863b6 100644
--- a/dlls/twain_32/dsm_ctrl.c
+++ b/dlls/twain_32/dsm_ctrl.c
@@ -233,12 +233,14 @@ TW_UINT16 TWAIN_OpenDS (pTW_IDENTITY pOr
 	if (!hmod) {
 		ERR("Failed to load TWAIN Source %s\n", modname);
 		DSM_twCC = TWCC_OPERATIONERROR;
+                HeapFree(GetProcessHeap(), 0, newSource);
 		return TWRC_FAILURE;
 	}
 	newSource->hmod = hmod; 
 	newSource->dsEntry = (DSENTRYPROC)GetProcAddress(hmod, "DS_Entry"); 
 	if (TWRC_SUCCESS != newSource->dsEntry (pOrigin, DG_CONTROL, DAT_IDENTITY, MSG_OPENDS, pIdentity)) {
 		DSM_twCC = TWCC_OPERATIONERROR;
+                HeapFree(GetProcessHeap(), 0, newSource);
 		return TWRC_FAILURE;
 	}
 	/* Assign name and id for the opened data source */




More information about the wine-cvs mailing list