Eric Pouech : dbghelp: Removed call to registered callback when unloading a module.

Alexandre Julliard julliard at wine.codeweavers.com
Thu May 11 05:56:25 CDT 2006


Module: wine
Branch: refs/heads/master
Commit: 2a1d8efde440f7c791bf9f3c675a278203c81ea6
URL:    http://source.winehq.org/git/?p=wine.git;a=commit;h=2a1d8efde440f7c791bf9f3c675a278203c81ea6

Author: Eric Pouech <eric.pouech at wanadoo.fr>
Date:   Wed May 10 21:35:47 2006 +0200

dbghelp: Removed call to registered callback when unloading a module.

First, native dbghelp doesn't do it, and it crashed windbg, likely
because we got the undocumented arguments wrong.

---

 dlls/dbghelp/module.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/dlls/dbghelp/module.c b/dlls/dbghelp/module.c
index 26b847a..9b138e3 100644
--- a/dlls/dbghelp/module.c
+++ b/dlls/dbghelp/module.c
@@ -520,9 +520,9 @@ BOOL module_remove(struct process* pcs, 
     HeapFree(GetProcessHeap(), 0, (char*)module->sources);
     HeapFree(GetProcessHeap(), 0, module->addr_sorttab);
     pool_destroy(&module->pool);
-    if (module->module.SymType != SymNone)
-        pcs_callback(pcs, CBA_SYMBOLS_UNLOADED, NULL);
-
+    /* native dbghelp doesn't invoke registered callback(,CBA_SYMBOLS_UNLOADED,) here
+     * so do we
+     */
     for (p = &pcs->lmodules; *p; p = &(*p)->next)
     {
         if (*p == module)




More information about the wine-cvs mailing list