Mikołaj Zalewski : comctl32: header: Ignore out-of-range iOrder in SetItemT.

Alexandre Julliard julliard at wine.codeweavers.com
Tue May 30 13:07:31 CDT 2006


Module: wine
Branch: refs/heads/master
Commit: 414128eb949b810f432ac1836880f7cd7b6b35e8
URL:    http://source.winehq.org/git/?p=wine.git;a=commit;h=414128eb949b810f432ac1836880f7cd7b6b35e8

Author: Mikołaj Zalewski <mikolaj at zalewski.pl>
Date:   Tue May 30 14:17:06 2006 +0200

comctl32: header: Ignore out-of-range iOrder in SetItemT.

---

 dlls/comctl32/header.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/comctl32/header.c b/dlls/comctl32/header.c
index d47e7f5..b00adc2 100644
--- a/dlls/comctl32/header.c
+++ b/dlls/comctl32/header.c
@@ -1460,9 +1460,9 @@ HEADER_SetItemT (HWND hwnd, INT nItem, L
     lpItem = &infoPtr->items[nItem];
     HEADER_StoreHDItemInHeader(lpItem, phdi->mask, phdi, bUnicode);
 
-    /* FIXME: check it order is not out of bound */
     if (phdi->mask & HDI_ORDER)
-        HEADER_ChangeItemOrder(infoPtr, nItem, phdi->iOrder);
+        if (phdi->iOrder >= 0 && phdi->iOrder < infoPtr->uNumItem)
+            HEADER_ChangeItemOrder(infoPtr, nItem, phdi->iOrder);
 
     HEADER_SendHeaderNotifyT (hwnd, HDN_ITEMCHANGEDW, nItem, phdi->mask, &hdNotify);
 




More information about the wine-cvs mailing list