Markus Amsler : d3d: Remove AddRef from IWineD3DDevice_GetIndices.

Alexandre Julliard julliard at wine.codeweavers.com
Wed Nov 22 05:21:39 CST 2006


Module: wine
Branch: master
Commit: 5c4008719c60af52e9370023f09c7b86b7768e85
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=5c4008719c60af52e9370023f09c7b86b7768e85

Author: Markus Amsler <markus.amsler at oribi.org>
Date:   Mon Nov 20 10:48:10 2006 +0100

d3d: Remove AddRef from IWineD3DDevice_GetIndices.

---

 dlls/d3d8/device.c    |    1 -
 dlls/d3d9/device.c    |    1 -
 dlls/wined3d/device.c |    2 --
 3 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/dlls/d3d8/device.c b/dlls/d3d8/device.c
index 2b4b6dd..99164e0 100644
--- a/dlls/d3d8/device.c
+++ b/dlls/d3d8/device.c
@@ -1311,7 +1311,6 @@ static HRESULT WINAPI IDirect3DDevice8Im
     rc = IWineD3DDevice_GetIndices(This->WineD3DDevice, &retIndexData, &tmp);
     if (D3D_OK == rc && NULL != retIndexData) {
         IWineD3DVertexBuffer_GetParent(retIndexData, (IUnknown **)ppIndexData);
-        IWineD3DVertexBuffer_Release(retIndexData);
     } else {
         if(rc != D3D_OK)  FIXME("Call to GetIndices failed\n");
         *ppIndexData = NULL;
diff --git a/dlls/d3d9/device.c b/dlls/d3d9/device.c
index d0a456a..8143981 100644
--- a/dlls/d3d9/device.c
+++ b/dlls/d3d9/device.c
@@ -833,7 +833,6 @@ static HRESULT  WINAPI  IDirect3DDevice9
     rc = IWineD3DDevice_GetIndices(This->WineD3DDevice, &retIndexData, &tmp);
     if (rc == D3D_OK && NULL != retIndexData) {
         IWineD3DVertexBuffer_GetParent(retIndexData, (IUnknown **)ppIndexData);
-        IWineD3DVertexBuffer_Release(retIndexData);
     }else{
         if(rc != D3D_OK)  FIXME("Call to GetIndices failed\n");
         *ppIndexData = NULL;
diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c
index 26d9c4b..51cc16b 100644
--- a/dlls/wined3d/device.c
+++ b/dlls/wined3d/device.c
@@ -3235,9 +3235,7 @@ static HRESULT WINAPI IWineD3DDeviceImpl
 
     *ppIndexData = This->stateBlock->pIndexData;
 
-    /* up ref count on ppindexdata */
     if (*ppIndexData) {
-        IWineD3DIndexBuffer_AddRef(*ppIndexData);
         *pBaseVertexIndex = This->stateBlock->baseVertexIndex;
         TRACE("(%p) index data set to %p + %u\n", This, ppIndexData, This->stateBlock->baseVertexIndex);
     }else{




More information about the wine-cvs mailing list