James Hawkins : dbghelp: Remove redundant NULL checks before pdb_free ( found by Smatch).

Alexandre Julliard julliard at wine.codeweavers.com
Fri Oct 6 13:37:10 CDT 2006


Module: wine
Branch: master
Commit: 1b95f6093868254b612138ae1136d2257a551b0f
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=1b95f6093868254b612138ae1136d2257a551b0f

Author: James Hawkins <truiken at gmail.com>
Date:   Thu Oct  5 19:38:54 2006 -0700

dbghelp: Remove redundant NULL checks before pdb_free (found by Smatch).

---

 dlls/dbghelp/msc.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/dlls/dbghelp/msc.c b/dlls/dbghelp/msc.c
index 46bb70b..a0b4960 100644
--- a/dlls/dbghelp/msc.c
+++ b/dlls/dbghelp/msc.c
@@ -1746,10 +1746,10 @@ static void pdb_free_lookup(const struct
     switch (pdb_lookup->kind)
     {
     case PDB_JG:
-        if (pdb_lookup->u.jg.toc) pdb_free(pdb_lookup->u.jg.toc);
+        pdb_free(pdb_lookup->u.jg.toc);
         break;
     case PDB_DS:
-        if (pdb_lookup->u.ds.toc) pdb_free(pdb_lookup->u.ds.toc);
+        pdb_free(pdb_lookup->u.ds.toc);
         break;
     }
 }
@@ -2193,7 +2193,7 @@ static BOOL pdb_process_internal(const s
 
  leave:
     /* Cleanup */
-    if (symbols_image) pdb_free(symbols_image);
+    pdb_free(symbols_image);
     pdb_free_lookup(pdb_lookup);
 
     if (image) UnmapViewOfFile(image);




More information about the wine-cvs mailing list