Jeff Latimer : ole32: Remove dead code in errorinfo.c (Coverity).

Alexandre Julliard julliard at wine.codeweavers.com
Sat Oct 14 14:13:41 CDT 2006


Module: wine
Branch: master
Commit: 6a355aec1b1c88cfe2927b072c48c57b5e5946dd
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=6a355aec1b1c88cfe2927b072c48c57b5e5946dd

Author: Jeff Latimer <lats at yless4u.com.au>
Date:   Sat Oct 14 19:51:43 2006 +1000

ole32: Remove dead code in errorinfo.c (Coverity).

---

 dlls/ole32/errorinfo.c |   10 +++-------
 1 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/dlls/ole32/errorinfo.c b/dlls/ole32/errorinfo.c
index 62e27e0..b7ce50a 100644
--- a/dlls/ole32/errorinfo.c
+++ b/dlls/ole32/errorinfo.c
@@ -83,14 +83,10 @@ static BSTR WINAPI ERRORINFO_SysAllocStr
     newBuffer++;
 
     /*
-     * Copy the information in the buffer.
-     * Since it is valid to pass a NULL pointer here, we'll initialize the
-     * buffer to nul if it is the case.
+     * Copy the information in the buffer.  It is not possible to pass 
+     * a NULL pointer here. 
      */
-    if (in != 0)
-      memcpy(newBuffer, in, bufferSize);
-    else
-      memset(newBuffer, 0, bufferSize);
+    memcpy(newBuffer, in, bufferSize);
 
     /*
      * Make sure that there is a nul character at the end of the




More information about the wine-cvs mailing list