Rob Shearman : oleaut32: Update comments at the top of typelib. c and remove "stub" from several traces that are in implemented functions.

Alexandre Julliard julliard at wine.codeweavers.com
Fri Oct 27 05:49:21 CDT 2006


Module: wine
Branch: master
Commit: 7f715458350dc2138f33acb921b4c49212011849
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=7f715458350dc2138f33acb921b4c49212011849

Author: Rob Shearman <rob at codeweavers.com>
Date:   Thu Oct 26 12:38:38 2006 +0100

oleaut32: Update comments at the top of typelib.c and remove "stub" from several traces that are in implemented functions.

---

 dlls/oleaut32/typelib.c |   12 ++----------
 1 files changed, 2 insertions(+), 10 deletions(-)

diff --git a/dlls/oleaut32/typelib.c b/dlls/oleaut32/typelib.c
index 0f8f287..8a7cf52 100644
--- a/dlls/oleaut32/typelib.c
+++ b/dlls/oleaut32/typelib.c
@@ -29,27 +29,19 @@
  * - dual interface dispinterfaces. vtable-interface ITypeInfo instances are
  *   creating by doing a straight copy of the dispinterface instance and just changing
  *   its typekind. Pointed structures aren't copied - only the address of the pointers.
- *   So when you release the dispinterface, you delete the vtable-interface structures
- *   as well... fortunately, clean up of structures is not implemented.
  *
  * - locale stuff is partially implemented but hasn't been tested.
  *
  * - typelib file is still read in its entirety, but it is released now.
- * - some garbage is read from function names on some very rare occasions.
  *
  * --------------------------------------------------------------------------------------
  *  Known problems left from previous implementation (1999, Rein Klazes) :
  *
  * -. Data structures are straightforward, but slow for look-ups.
  * -. (related) nothing is hashed
- * -. there are a number of stubs in ITypeLib and ITypeInfo interfaces. Most
- *      of them I don't know yet how to implement them.
  * -. Most error return values are just guessed not checked with windows
  *      behaviour.
- * -. didn't bother with a c++ interface
  * -. lousy fatal error handling
- * -. some methods just return pointers to internal data structures, this is
- *      partly laziness, partly I want to check how windows does it.
  *
  */
 
@@ -739,7 +731,7 @@ HRESULT WINAPI UnRegisterTypeLib(
     ITypeLib* typeLib = NULL;
     int numTypes;
 
-    TRACE("(IID: %s): stub\n",debugstr_guid(libid));
+    TRACE("(IID: %s)\n",debugstr_guid(libid));
 
     /* Create the path to the key */
     get_typelib_key( libid, wVerMajor, wVerMinor, keyName );
@@ -4542,7 +4534,7 @@ static HRESULT WINAPI ITypeInfo_fnGetTyp
 {
     ITypeInfoImpl *This = (ITypeInfoImpl *)iface;
 
-    TRACE("(%p)->(%p) stub!\n", This, ppTComp);
+    TRACE("(%p)->(%p)\n", This, ppTComp);
 
     *ppTComp = (ITypeComp *)&This->lpVtblTypeComp;
     ITypeComp_AddRef(*ppTComp);




More information about the wine-cvs mailing list