Rob Shearman : atl: AddRef the object being returned in AtlInternalQueryInterface, not "this" .

Alexandre Julliard julliard at wine.codeweavers.com
Wed Apr 4 12:32:25 CDT 2007


Module: wine
Branch: master
Commit: 99c0335222b244b34f73e86c4e7e5f2d555ec3a7
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=99c0335222b244b34f73e86c4e7e5f2d555ec3a7

Author: Rob Shearman <rob at codeweavers.com>
Date:   Tue Apr  3 18:14:22 2007 +0100

atl: AddRef the object being returned in AtlInternalQueryInterface,  not "this".

---

 dlls/atl/atl_main.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/dlls/atl/atl_main.c b/dlls/atl/atl_main.c
index b03effc..69d62e7 100644
--- a/dlls/atl/atl_main.c
+++ b/dlls/atl/atl_main.c
@@ -235,7 +235,7 @@ HRESULT WINAPI AtlInternalQueryInterface(void* this, const _ATL_INTMAP_ENTRY* pE
             {
                 TRACE("Offset\n");
                 *ppvObject = ((LPSTR)this+pEntries[i].dw);
-                IUnknown_AddRef((IUnknown*)this);
+                IUnknown_AddRef((IUnknown*)*ppvObject);
                 rc = S_OK;
             }
             else




More information about the wine-cvs mailing list