Rob Shearman : msi: Fix an off-by-one error when calculating the path and filename for the action data in the SelfRegModules action .

Alexandre Julliard julliard at wine.codeweavers.com
Wed Apr 25 07:06:29 CDT 2007


Module: wine
Branch: master
Commit: 220f93db6115ff29ab066551ae0d1ffb1eccd483
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=220f93db6115ff29ab066551ae0d1ffb1eccd483

Author: Rob Shearman <rob at codeweavers.com>
Date:   Tue Apr 24 12:33:56 2007 +0100

msi: Fix an off-by-one error when calculating the path and filename for the action data in the SelfRegModules action.

The backslash is in p[0], not p[1].

---

 dlls/msi/action.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/msi/action.c b/dlls/msi/action.c
index dbf48f4..7ee0518 100644
--- a/dlls/msi/action.c
+++ b/dlls/msi/action.c
@@ -3498,8 +3498,8 @@ static UINT ITERATE_SelfRegModules(MSIRECORD *row, LPVOID param)
     uipath = strdupW( file->TargetPath );
     p = strrchrW(uipath,'\\');
     if (p)
-        p[1]=0;
-    MSI_RecordSetStringW( uirow, 1, &p[2] );
+        p[0]=0;
+    MSI_RecordSetStringW( uirow, 1, &p[1] );
     MSI_RecordSetStringW( uirow, 2, uipath);
     ui_actiondata( package, szSelfRegModules, uirow);
     msiobj_release( &uirow->hdr );




More information about the wine-cvs mailing list