Michael Stefaniuc : dsound: Remove redundant NULL check before HeapFree. Found by Smatch.

Alexandre Julliard julliard at wine.codeweavers.com
Mon Aug 6 08:03:34 CDT 2007


Module: wine
Branch: master
Commit: efe4573bc8b816e95c642e89b4d40427c26be224
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=efe4573bc8b816e95c642e89b4d40427c26be224

Author: Michael Stefaniuc <mstefani at redhat.de>
Date:   Sat Aug  4 00:57:05 2007 +0200

dsound: Remove redundant NULL check before HeapFree. Found by Smatch.

---

 dlls/dsound/primary.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/dlls/dsound/primary.c b/dlls/dsound/primary.c
index 557422a..355fc2c 100644
--- a/dlls/dsound/primary.c
+++ b/dlls/dsound/primary.c
@@ -253,10 +253,8 @@ HRESULT DSOUND_PrimaryDestroy(DirectSoundDevice *device)
 			if (IDsDriverBuffer_Release(device->hwbuf) == 0)
 				device->hwbuf = 0;
 		}
-	} else {
-		if (device->pwave)
-			HeapFree(GetProcessHeap(),0,device->pwave);
-	}
+	} else
+                HeapFree(GetProcessHeap(),0,device->pwave);
         HeapFree(GetProcessHeap(),0,device->pwfx);
         device->pwfx=NULL;
 




More information about the wine-cvs mailing list