Rob Shearman : secur32: Remove valid_session_key from NegoHelper since it is only ever set and not read .

Alexandre Julliard julliard at wine.codeweavers.com
Wed Aug 8 08:59:25 CDT 2007


Module: wine
Branch: master
Commit: 610a3b1ad2e6e5e62e5e422f794f9779cbbb0313
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=610a3b1ad2e6e5e62e5e422f794f9779cbbb0313

Author: Rob Shearman <rob at codeweavers.com>
Date:   Tue Aug  7 17:12:54 2007 +0100

secur32: Remove valid_session_key from NegoHelper since it is only ever set and not read.

---

 dlls/secur32/ntlm.c         |    4 ----
 dlls/secur32/secur32_priv.h |    1 -
 2 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/dlls/secur32/ntlm.c b/dlls/secur32/ntlm.c
index 3300439..21fbc59 100644
--- a/dlls/secur32/ntlm.c
+++ b/dlls/secur32/ntlm.c
@@ -786,7 +786,6 @@ static SECURITY_STATUS SEC_ENTRY ntlm_InitializeSecurityContextW(
                 TRACE("Failed to decode session key\n");
             }
             TRACE("Session key is %s\n", debugstr_a(buffer+3));
-            helper->valid_session_key = TRUE;
             HeapFree(GetProcessHeap(), 0, helper->session_key);
             helper->session_key = HeapAlloc(GetProcessHeap(), 0, bin_len);
             if(!helper->session_key)
@@ -1155,7 +1154,6 @@ static SECURITY_STATUS SEC_ENTRY ntlm_AcceptSecurityContext(
             if(strncmp(buffer, "BH ", 3) == 0)
             {
                 TRACE("Helper sent %s\n", debugstr_a(buffer+3));
-                helper->valid_session_key = FALSE;
                 helper->session_key = HeapAlloc(GetProcessHeap(), 0, 16);
                 /*FIXME: Generate the dummy session key = MD4(MD4(password))*/
                 memset(helper->session_key, 0 , 16);
@@ -1168,7 +1166,6 @@ static SECURITY_STATUS SEC_ENTRY ntlm_AcceptSecurityContext(
                     TRACE("Failed to decode session key\n");
                 }
                 TRACE("Session key is %s\n", debugstr_a(buffer+3));
-                helper->valid_session_key = TRUE;
                 helper->session_key = HeapAlloc(GetProcessHeap(), 0, 16);
                 if(!helper->session_key)
                 {
@@ -1226,7 +1223,6 @@ static SECURITY_STATUS SEC_ENTRY ntlm_DeleteSecurityContext(PCtxtHandle phContex
 
     SECUR32_arc4Cleanup(helper->crypt.ntlm.a4i);
     HeapFree(GetProcessHeap(), 0, helper->session_key);
-    helper->valid_session_key = FALSE;
     SECUR32_arc4Cleanup(helper->crypt.ntlm2.send_a4i);
     SECUR32_arc4Cleanup(helper->crypt.ntlm2.recv_a4i);
     HeapFree(GetProcessHeap(), 0, helper->crypt.ntlm2.send_sign_key);
diff --git a/dlls/secur32/secur32_priv.h b/dlls/secur32/secur32_priv.h
index a11cc20..303d8fc 100644
--- a/dlls/secur32/secur32_priv.h
+++ b/dlls/secur32/secur32_priv.h
@@ -70,7 +70,6 @@ typedef struct _NegoHelper {
     int com_buf_size;
     int com_buf_offset;
     BYTE *session_key;
-    BOOL valid_session_key;
     unsigned long neg_flags;
     struct {
         struct {




More information about the wine-cvs mailing list