appdb/. screenshots.php

WineHQ wineowner at wine.codeweavers.com
Wed Aug 22 21:33:57 CDT 2007


ChangeSet ID:	31336
CVSROOT:	/opt/cvs-commit
Module name:	appdb
Changes by:	wineowner at winehq.org	2007/08/22 21:33:57

Modified files:
	.              : screenshots.php 

Log message:
	Chris Morgan <cmorgan at alum.wpi.edu>
	Remove logic that was preventing the opening of the version frame. The code to open the version
	frame also determins if the user maintains the version or not, which decides whether we include
	the "Delete Image" link. Change fixes missing "Delete Image" link for maintainers.

Patch: http://cvs.winehq.org/patch.py?id=31336

Old revision  New revision  Changes     Path
 1.49          1.50          +6 -4       appdb/screenshots.php

Index: appdb/screenshots.php
diff -u -p appdb/screenshots.php:1.49 appdb/screenshots.php:1.50
--- appdb/screenshots.php:1.49	23 Aug 2007  2:33:57 -0000
+++ appdb/screenshots.php	23 Aug 2007  2:33:57 -0000
@@ -62,7 +62,7 @@ $oVersion = new Version($aClean['iVersio
 
 if($hResult && query_num_rows($hResult))
 {
-    echo html_frame_start("Screenshot Gallery for ".$oApp->sName." ".$oVersion->sName,500);
+    echo html_frame_start("Screenshot Gallery for ".$oApp->sName, 500);
 
     // display thumbnails
     $c = 1;
@@ -77,7 +77,7 @@ if($hResult && query_num_rows($hResult))
         // if the current version changed then update the current version
         // and close the previous html frame if this isn't the
         // first frame
-        if(!$aClean['iVersionId'] && $oRow->versionId != $iCurrentVersionId)
+        if($oRow->versionId != $iCurrentVersionId)
         {
             if($iCurrentVersionId)
             {
@@ -86,13 +86,14 @@ if($hResult && query_num_rows($hResult))
                 $c=1;
             }
             $iCurrentVersionId = $oRow->versionId;
-            $bUserIsMaintainerOfVersion = $_SESSION['current']->isMaintainer($iCurrentVersionId); 
+            $bUserIsMaintainerOfVersion = $_SESSION['current']->isMaintainer($iCurrentVersionId);
 
             echo html_frame_start("Version ".Version::lookup_name($iCurrentVersionId));
             echo "<div align=center><table><tr>\n";
         }
         $oScreenshot = new Screenshot($oRow->id);
         $img = $oScreenshot->get_thumbnail_img();
+
         // display image
         echo "<td>\n";
         echo $img;
@@ -120,7 +121,8 @@ if($hResult && query_num_rows($hResult))
 
     echo html_frame_end(); // close the current version we are displaying
     echo html_frame_end(); // close the "Screenshot Gallary..." html frame
-} else {
+} else
+{
  echo "<p align=\"center\">There are currently no screenshots for the selected version of this application.";
  echo "<br />Please consider submitting a screenshot for the selected version yourself.</p>";
 }



More information about the wine-cvs mailing list