Rob Shearman : ole32: Initialise object variable in RunningObjectTableImpl_GetObject.

Alexandre Julliard julliard at winehq.org
Thu Dec 6 08:26:45 CST 2007


Module: wine
Branch: master
Commit: 3328ad6eb977b5e0d0208d71f4cbca7ea4400138
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=3328ad6eb977b5e0d0208d71f4cbca7ea4400138

Author: Rob Shearman <rob at codeweavers.com>
Date:   Wed Dec  5 16:09:58 2007 +0000

ole32: Initialise object variable in RunningObjectTableImpl_GetObject.

As per the rules for memory in RPC, the memory pointer to by object will 
be used during unmarshalling and previously it was uninitialised.
(Thanks to Dan Kegel and his Valgrind runs for reporting this.)

---

 dlls/ole32/moniker.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/dlls/ole32/moniker.c b/dlls/ole32/moniker.c
index c4975b9..cbb89e5 100644
--- a/dlls/ole32/moniker.c
+++ b/dlls/ole32/moniker.c
@@ -693,7 +693,7 @@ RunningObjectTableImpl_GetObject( IRunningObjectTable* iface,
 {
     RunningObjectTableImpl *This = (RunningObjectTableImpl *)iface;
     MonikerComparisonData *moniker_data;
-    InterfaceData *object;
+    InterfaceData *object = NULL;
     IrotCookie cookie;
     HRESULT hr;
     struct rot_entry *rot_entry;




More information about the wine-cvs mailing list