Lei Zhang : quartz: Fix return value in IFilterGraph_FindFilterByName.
Alexandre Julliard
julliard at winehq.org
Fri Dec 7 11:02:07 CST 2007
Module: wine
Branch: master
Commit: 31aab429340ac5c65adea83b769b36121507ba41
URL: http://source.winehq.org/git/wine.git/?a=commit;h=31aab429340ac5c65adea83b769b36121507ba41
Author: Lei Zhang <thestig at google.com>
Date: Wed Dec 5 20:11:13 2007 -0800
quartz: Fix return value in IFilterGraph_FindFilterByName.
---
dlls/quartz/filtergraph.c | 2 +-
dlls/quartz/tests/filtergraph.c | 4 +---
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/dlls/quartz/filtergraph.c b/dlls/quartz/filtergraph.c
index a64562a..e583cee 100644
--- a/dlls/quartz/filtergraph.c
+++ b/dlls/quartz/filtergraph.c
@@ -495,7 +495,7 @@ static HRESULT WINAPI GraphBuilder_FindFilterByName(IGraphBuilder *iface,
}
}
- return E_FAIL; /* FIXME: check this error code */
+ return VFW_E_NOT_FOUND;
}
/* NOTE: despite the implication, it doesn't matter which
diff --git a/dlls/quartz/tests/filtergraph.c b/dlls/quartz/tests/filtergraph.c
index abdaa09..85cce7c 100644
--- a/dlls/quartz/tests/filtergraph.c
+++ b/dlls/quartz/tests/filtergraph.c
@@ -138,9 +138,7 @@ static void test_graph_builder(void)
ok(dir == PINDIR_INPUT, "pin has wrong direction\n");
hr = IGraphBuilder_FindFilterByName(pgraph, fooBarW, &pF2);
- todo_wine {
- ok(hr == VFW_E_NOT_FOUND, "IGraphBuilder_FindFilterByName returned %x\n", hr);
- }
+ ok(hr == VFW_E_NOT_FOUND, "IGraphBuilder_FindFilterByName returned %x\n", hr);
ok(pF2 == NULL, "IGraphBuilder_FindFilterByName returned %p\n", pF2);
hr = IGraphBuilder_FindFilterByName(pgraph, testFilterW, &pF2);
ok(hr == S_OK, "IGraphBuilder_FindFilterByName returned %x\n", hr);
More information about the wine-cvs
mailing list