Stefan Dösinger : wined3d: Do not keep internal references on pixel shaders.

Alexandre Julliard julliard at wine.codeweavers.com
Mon Jan 8 14:44:14 CST 2007


Module: wine
Branch: master
Commit: 467fa4e702ff11728cc5d7c335a3b89fa821ec52
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=467fa4e702ff11728cc5d7c335a3b89fa821ec52

Author: Stefan Dösinger <stefan at codeweavers.com>
Date:   Sat Jan  6 18:25:47 2007 +0100

wined3d: Do not keep internal references on pixel shaders.

---

 dlls/wined3d/device.c     |    7 -------
 dlls/wined3d/stateblock.c |   11 -----------
 2 files changed, 0 insertions(+), 18 deletions(-)

diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c
index acc3bbb..1a71afa 100644
--- a/dlls/wined3d/device.c
+++ b/dlls/wined3d/device.c
@@ -3531,13 +3531,6 @@ static HRESULT WINAPI IWineD3DDeviceImpl
         TRACE("Recording... not performing anything\n");
     }
 
-    if (NULL != pShader) {
-        IWineD3DPixelShader_AddRef(pShader);
-    }
-    if (NULL != oldShader) {
-        IWineD3DPixelShader_Release(oldShader);
-    }
-
     if (This->isRecordingState) {
         TRACE("Recording... not performing anything\n");
         return WINED3D_OK;
diff --git a/dlls/wined3d/stateblock.c b/dlls/wined3d/stateblock.c
index 5e36c5d..439f0d2 100644
--- a/dlls/wined3d/stateblock.c
+++ b/dlls/wined3d/stateblock.c
@@ -246,10 +246,6 @@ static ULONG  WINAPI IWineD3DStateBlockI
                 This->pIndexData = NULL;
             }
 
-            if (NULL != This->pixelShader) {
-                IWineD3DPixelShader_Release(This->pixelShader);
-            }
-
             /* NOTE: according to MSDN: The application is responsible for making sure the texture references are cleared down */
             for (counter = 0; counter < GL_LIMITS(sampler_stages); counter++) {
                 if (This->textures[counter]) {
@@ -414,13 +410,6 @@ static HRESULT  WINAPI IWineD3DStateBloc
         if (This->pixelShader != targetStateBlock->pixelShader) {
             TRACE("Updating pixel shader from %p to %p\n", This->pixelShader, targetStateBlock->pixelShader);
 
-            if (targetStateBlock->pixelShader) {
-                IWineD3DPixelShader_AddRef(targetStateBlock->pixelShader);
-            }
-            if (This->pixelShader) {
-                IWineD3DPixelShader_Release(This->pixelShader);
-            }
-
             This->pixelShader = targetStateBlock->pixelShader;
         }
 




More information about the wine-cvs mailing list