James Hawkins : msi: Return ERROR_SUCCESS if the PackageName property is not present.

Alexandre Julliard julliard at wine.codeweavers.com
Mon Jul 2 09:52:17 CDT 2007


Module: wine
Branch: master
Commit: c26505b7016fa593c46a1e9666ba97ceee7f9cef
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=c26505b7016fa593c46a1e9666ba97ceee7f9cef

Author: James Hawkins <truiken at gmail.com>
Date:   Fri Jun 29 14:12:52 2007 -0700

msi: Return ERROR_SUCCESS if the PackageName property is not present.

---

 dlls/msi/source.c       |    2 +-
 dlls/msi/tests/source.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/msi/source.c b/dlls/msi/source.c
index 70a9552..74e2881 100644
--- a/dlls/msi/source.c
+++ b/dlls/msi/source.c
@@ -344,7 +344,7 @@ UINT WINAPI MsiSourceListGetInfoW( LPCWSTR szProduct, LPCWSTR szUserSid,
         rc = RegQueryValueExW(sourcekey, INSTALLPROPERTY_PACKAGENAMEW, 0, 0, 
                 (LPBYTE)szValue, pcchValue);
         if (rc != ERROR_SUCCESS && rc != ERROR_MORE_DATA)
-            rc = ERROR_UNKNOWN_PROPERTY;
+            rc = ERROR_SUCCESS;
     }
     else
     {
diff --git a/dlls/msi/tests/source.c b/dlls/msi/tests/source.c
index b87d1ba..2c2fe05 100644
--- a/dlls/msi/tests/source.c
+++ b/dlls/msi/tests/source.c
@@ -208,9 +208,9 @@ static void test_MsiSourceListGetInfo(void)
     size = 0xdeadbeef;
     r = MsiSourceListGetInfoA(prodcode, usersid, MSIINSTALLCONTEXT_USERUNMANAGED,
                               MSICODE_PRODUCT, INSTALLPROPERTY_PACKAGENAME, NULL, &size);
+    ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", r);
     todo_wine
     {
-        ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", r);
         ok(size == 0, "Expected 0, got %d\n", size);
     }
 




More information about the wine-cvs mailing list