Paul Vriens : advapi/service: Fix possible handle leak.

Alexandre Julliard julliard at wine.codeweavers.com
Thu Jul 12 08:32:24 CDT 2007


Module: wine
Branch: master
Commit: 13b3b724c6cf9f4dc01749a84a1048e382f8346c
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=13b3b724c6cf9f4dc01749a84a1048e382f8346c

Author: Paul Vriens <paul.vriens.wine at gmail.com>
Date:   Wed Jul 11 20:43:01 2007 +0200

advapi/service: Fix possible handle leak.

---

 dlls/advapi32/service.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/dlls/advapi32/service.c b/dlls/advapi32/service.c
index 462abdb..55e9716 100644
--- a/dlls/advapi32/service.c
+++ b/dlls/advapi32/service.c
@@ -1262,7 +1262,10 @@ SC_HANDLE WINAPI OpenServiceW( SC_HANDLE hSCManager, LPCWSTR lpServiceName,
                             sizeof (struct sc_service) + len*sizeof(WCHAR),
                             sc_handle_destroy_service );
     if (!hsvc)
+    {
+        RegCloseKey(hKey);
         return NULL;
+    }
     strcpyW( hsvc->name, lpServiceName );
     hsvc->hkey = hKey;
     hsvc->dwAccess = dwDesiredAccess;




More information about the wine-cvs mailing list