Rob Shearman : ole32:
Add warnings for failures in the structured storage stream functions.
Alexandre Julliard
julliard at wine.codeweavers.com
Tue Mar 20 08:11:00 CDT 2007
Module: wine
Branch: master
Commit: 05e99099af7a7cee30c6d0c4b409f4bb2cbe46d5
URL: http://source.winehq.org/git/wine.git/?a=commit;h=05e99099af7a7cee30c6d0c4b409f4bb2cbe46d5
Author: Rob Shearman <rob at codeweavers.com>
Date: Mon Mar 19 14:53:41 2007 +0000
ole32: Add warnings for failures in the structured storage stream functions.
---
dlls/ole32/stg_stream.c | 30 ++++++++++++++++++++++++++++++
1 files changed, 30 insertions(+), 0 deletions(-)
diff --git a/dlls/ole32/stg_stream.c b/dlls/ole32/stg_stream.c
index 6f2ec9a..e144b2c 100644
--- a/dlls/ole32/stg_stream.c
+++ b/dlls/ole32/stg_stream.c
@@ -486,7 +486,10 @@ static HRESULT WINAPI StgStreamImpl_Seek(
*/
if (!This->parentStorage)
+ {
+ WARN("storage reverted\n");
return STG_E_REVERTED;
+ }
/*
* The caller is allowed to pass in NULL as the new position return value.
@@ -515,6 +518,7 @@ static HRESULT WINAPI StgStreamImpl_Seek(
*plibNewPosition = This->streamSize;
break;
default:
+ WARN("invalid dwOrigin %d\n", dwOrigin);
return STG_E_INVALIDFUNCTION;
}
@@ -549,19 +553,28 @@ static HRESULT WINAPI StgStreamImpl_SetSize(
TRACE("(%p, %d)\n", iface, libNewSize.u.LowPart);
if(!This->parentStorage)
+ {
+ WARN("storage reverted\n");
return STG_E_REVERTED;
+ }
/*
* As documented.
*/
if (libNewSize.u.HighPart != 0)
+ {
+ WARN("invalid value for libNewSize.u.HighPart %d\n", libNewSize.u.HighPart);
return STG_E_INVALIDFUNCTION;
+ }
/*
* Do we have permission?
*/
if (!(This->grfMode & (STGM_WRITE | STGM_READWRITE)))
+ {
+ WARN("access denied\n");
return STG_E_ACCESSDENIED;
+ }
if (This->streamSize.u.LowPart == libNewSize.u.LowPart)
return S_OK;
@@ -669,7 +682,10 @@ static HRESULT WINAPI StgStreamImpl_CopyTo(
*/
if (!This->parentStorage)
+ {
+ WARN("storage reverted\n");
return STG_E_REVERTED;
+ }
if ( pstm == 0 )
return STG_E_INVALIDPOINTER;
@@ -703,6 +719,7 @@ static HRESULT WINAPI StgStreamImpl_CopyTo(
if (bytesRead != bytesWritten)
{
hr = STG_E_MEDIUMFULL;
+ WARN("medium full\n");
break;
}
@@ -744,7 +761,10 @@ static HRESULT WINAPI StgStreamImpl_Commit(
StgStreamImpl* const This=(StgStreamImpl*)iface;
if (!This->parentStorage)
+ {
+ WARN("storage reverted\n");
return STG_E_REVERTED;
+ }
return S_OK;
}
@@ -772,7 +792,10 @@ static HRESULT WINAPI StgStreamImpl_LockRegion(
StgStreamImpl* const This=(StgStreamImpl*)iface;
if (!This->parentStorage)
+ {
+ WARN("storage reverted\n");
return STG_E_REVERTED;
+ }
FIXME("not implemented!\n");
return E_NOTIMPL;
@@ -787,7 +810,10 @@ static HRESULT WINAPI StgStreamImpl_UnlockRegion(
StgStreamImpl* const This=(StgStreamImpl*)iface;
if (!This->parentStorage)
+ {
+ WARN("storage reverted\n");
return STG_E_REVERTED;
+ }
FIXME("not implemented!\n");
return E_NOTIMPL;
@@ -818,7 +844,10 @@ static HRESULT WINAPI StgStreamImpl_Stat(
*/
if (!This->parentStorage)
+ {
+ WARN("storage reverted\n");
return STG_E_REVERTED;
+ }
/*
* Read the information from the property.
@@ -838,6 +867,7 @@ static HRESULT WINAPI StgStreamImpl_Stat(
return S_OK;
}
+ WARN("failed to read properties\n");
return E_FAIL;
}
More information about the wine-cvs
mailing list