appdb/include testData.php

WineHQ wineowner at wine.codeweavers.com
Sun Mar 25 16:04:33 CDT 2007


ChangeSet ID:	31012
CVSROOT:	/opt/cvs-commit
Module name:	appdb
Changes by:	wineowner at winehq.org	2007/03/25 16:04:33

Modified files:
	include        : testData.php 

Log message:
	Chris Morgan <cmorgan at alum.wpi.edu>
	Implement Alexander's suggestion and use version::fullName() to reduce code duplication

Patch: http://cvs.winehq.org/patch.py?id=31012

Old revision  New revision  Changes     Path
 1.33          1.34          +2 -12      appdb/include/testData.php

Index: appdb/include/testData.php
diff -u -p appdb/include/testData.php:1.33 appdb/include/testData.php:1.34
--- appdb/include/testData.php:1.33	25 Mar 2007 21: 4:33 -0000
+++ appdb/include/testData.php	25 Mar 2007 21: 4:33 -0000
@@ -244,16 +244,6 @@ class testData{
         }
     }
 
-    function getFormattedApplicationVersionName()
-    {
-        $oVersion = new Version($this->iVersionId);
-        $sAppName = application::lookup_name($oVersion->iAppId);
-        $sVersionName = version::lookup_name($oVersion->iVersionId);
-        $sName = "$sAppName: $sVersionName";
-
-        return $sName;        
-    }
-
     function mailSubmitter($sAction="add")
     {
         global $aClean;
@@ -263,7 +253,7 @@ class testData{
             $oSubmitter = new User($this->iSubmitterId);
 
             /* Get the full app/version name to display */
-            $sName = $this->getFormattedApplicationVersionName();
+            $sName = version::fullName($this->iVersionId);
 
             switch($sAction)
             {
@@ -493,7 +483,7 @@ class testData{
     {
         HtmlAreaLoaderScript(array("Test1", "Test2", "Test3"));
 
-        $sName = $this->getFormattedApplicationVersionName();
+        $sName = version::fullName($this->iVersionId);
 
         echo html_frame_start("Test Form - $sName", "90%", "", 0);
         echo "<table width='100%' border=0 cellpadding=2 cellspacing=0>\n";



More information about the wine-cvs mailing list