Rob Shearman : ole32:
Remove spurious AddRef of returned object on retrieval of an interface
from the global interface table .
Alexandre Julliard
julliard at wine.codeweavers.com
Wed May 23 08:10:56 CDT 2007
Module: wine
Branch: master
Commit: 30cc21196e3b1397ba64e5fa2621bbde535c9bfc
URL: http://source.winehq.org/git/wine.git/?a=commit;h=30cc21196e3b1397ba64e5fa2621bbde535c9bfc
Author: Rob Shearman <rob at codeweavers.com>
Date: Tue May 22 10:32:55 2007 +0100
ole32: Remove spurious AddRef of returned object on retrieval of an interface from the global interface table.
---
dlls/ole32/git.c | 4 ----
dlls/ole32/tests/marshal.c | 1 -
2 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/dlls/ole32/git.c b/dlls/ole32/git.c
index c310249..e878f83 100644
--- a/dlls/ole32/git.c
+++ b/dlls/ole32/git.c
@@ -262,7 +262,6 @@ StdGlobalInterfaceTable_GetInterfaceFromGlobal(
{
StdGITEntry* entry;
HRESULT hres;
- LPUNKNOWN lpUnk;
IStream *stream;
TRACE("dwCookie=0x%x, riid=%s, ppv=%p\n", dwCookie, debugstr_guid(riid), ppv);
@@ -296,9 +295,6 @@ StdGlobalInterfaceTable_GetInterfaceFromGlobal(
return hres;
}
- /* addref it */
- lpUnk = *ppv;
- IUnknown_AddRef(lpUnk);
TRACE("ppv=%p\n", *ppv);
return S_OK;
}
diff --git a/dlls/ole32/tests/marshal.c b/dlls/ole32/tests/marshal.c
index 0b3cfeb..b089913 100644
--- a/dlls/ole32/tests/marshal.c
+++ b/dlls/ole32/tests/marshal.c
@@ -2651,7 +2651,6 @@ static void test_globalinterfacetable(void)
hr = IGlobalInterfaceTable_RevokeInterfaceFromGlobal(git, cookie);
ok_ole_success(hr, IGlobalInterfaceTable_RevokeInterfaceFromGlobal);
- todo_wine
ok_no_locks();
IGlobalInterfaceTable_Release(git);
More information about the wine-cvs
mailing list