Lei Zhang : wininet: Skip strcmp() in a test if the returned value/ len is wrong.

Alexandre Julliard julliard at winehq.org
Fri Nov 9 07:44:23 CST 2007


Module: wine
Branch: master
Commit: 83a4dbaa689d54f12ce05011c9f41b7637f3b75b
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=83a4dbaa689d54f12ce05011c9f41b7637f3b75b

Author: Lei Zhang <thestig at google.com>
Date:   Fri Nov  9 01:24:35 2007 -0800

wininet: Skip strcmp() in a test if the returned value/len is wrong.

---

 dlls/wininet/tests/internet.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/dlls/wininet/tests/internet.c b/dlls/wininet/tests/internet.c
index 9fac11e..c441bf2 100644
--- a/dlls/wininet/tests/internet.c
+++ b/dlls/wininet/tests/internet.c
@@ -142,9 +142,12 @@ static void test_InternetQueryOptionA(void)
   buffer=HeapAlloc(GetProcessHeap(),0,len);
   retval=InternetQueryOptionA(hinet,INTERNET_OPTION_USER_AGENT,buffer,&len);
   err=GetLastError();
-  todo_wine ok(!strcmp(useragent,buffer),"Got wrong user agent string %s instead of %s\n",buffer,useragent);
-  todo_wine ok(len == strlen(useragent),"Got wrong user agent length %d instead of %d\n",len,lstrlenA(useragent));
   todo_wine ok(retval == 1,"Got wrong return value %d\n",retval);
+  if (retval)
+  {
+      todo_wine ok(!strcmp(useragent,buffer),"Got wrong user agent string %s instead of %s\n",buffer,useragent);
+      todo_wine ok(len == strlen(useragent),"Got wrong user agent length %d instead of %d\n",len,lstrlenA(useragent));
+  }
   ok(err == 0xdeadbeef, "Got wrong error code %d\n",err);
   HeapFree(GetProcessHeap(),0,buffer);
 




More information about the wine-cvs mailing list