Huw Davies : msxml3: Don't leak an interface on failure.

Alexandre Julliard julliard at winehq.org
Fri Nov 16 08:31:13 CST 2007


Module: wine
Branch: master
Commit: 02be3e260abb53807b85d79f0431828545597633
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=02be3e260abb53807b85d79f0431828545597633

Author: Huw Davies <huw at codeweavers.com>
Date:   Thu Nov 15 10:25:15 2007 +0000

msxml3: Don't leak an interface on failure.

---

 dlls/msxml3/factory.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/dlls/msxml3/factory.c b/dlls/msxml3/factory.c
index 334906f..67ed747 100644
--- a/dlls/msxml3/factory.c
+++ b/dlls/msxml3/factory.c
@@ -109,8 +109,6 @@ static HRESULT WINAPI xmlcf_CreateInstance(
         return r;
 
     r = IUnknown_QueryInterface( punk, riid, ppobj );
-    if (FAILED(r))
-        return r;
     IUnknown_Release( punk );
     return r;
 }




More information about the wine-cvs mailing list