Alexandre Julliard : user32/tests: Avoid testing uninitialized data.

Alexandre Julliard julliard at winehq.org
Thu Apr 10 04:39:24 CDT 2008


Module: wine
Branch: master
Commit: e3ac70c1cbdd9f61272900b29229218a33bf709f
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=e3ac70c1cbdd9f61272900b29229218a33bf709f

Author: Alexandre Julliard <julliard at winehq.org>
Date:   Thu Apr 10 09:45:34 2008 +0200

user32/tests: Avoid testing uninitialized data.

---

 dlls/user32/tests/cursoricon.c |   13 +++++++------
 1 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/dlls/user32/tests/cursoricon.c b/dlls/user32/tests/cursoricon.c
index 2febfbb..7ea79ad 100644
--- a/dlls/user32/tests/cursoricon.c
+++ b/dlls/user32/tests/cursoricon.c
@@ -649,13 +649,14 @@ static void test_LoadImage(void)
     error = GetLastError();
     ok(error == 0xdeadbeef, "Last error: %u\n", error);
 
-    todo_wine {
-    ok(icon_info.fIcon == FALSE, "fIcon != FALSE.\n");
-    ok(icon_info.xHotspot == 1, "xHotspot is %u.\n", icon_info.xHotspot);
-    ok(icon_info.yHotspot == 1, "yHotspot is %u.\n", icon_info.yHotspot);
-    ok(icon_info.hbmColor != NULL, "No hbmColor!\n");
+    if (ret)
+    {
+        ok(icon_info.fIcon == FALSE, "fIcon != FALSE.\n");
+        ok(icon_info.xHotspot == 1, "xHotspot is %u.\n", icon_info.xHotspot);
+        ok(icon_info.yHotspot == 1, "yHotspot is %u.\n", icon_info.yHotspot);
+        ok(icon_info.hbmColor != NULL, "No hbmColor!\n");
+        ok(icon_info.hbmMask != NULL, "No hbmMask!\n");
     }
-    ok(icon_info.hbmMask != NULL, "No hbmMask!\n");
 
     /* Clean up. */
     SetLastError(0xdeadbeef);




More information about the wine-cvs mailing list