Jacek Caban : mshtml: Use heap_alloc_zero for allocating node objects.

Alexandre Julliard julliard at winehq.org
Thu Apr 24 06:23:09 CDT 2008


Module: wine
Branch: master
Commit: 38b14274fb507d1b6d387b38875f85720a5ee78d
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=38b14274fb507d1b6d387b38875f85720a5ee78d

Author: Jacek Caban <jacek at codeweavers.com>
Date:   Wed Apr 23 16:44:21 2008 +0200

mshtml: Use heap_alloc_zero for allocating node objects.

---

 dlls/mshtml/htmlanchor.c   |    2 +-
 dlls/mshtml/htmlbody.c     |    2 +-
 dlls/mshtml/htmlelem.c     |    2 +-
 dlls/mshtml/htmlinput.c    |    2 +-
 dlls/mshtml/htmlnode.c     |    3 +--
 dlls/mshtml/htmloption.c   |    2 +-
 dlls/mshtml/htmlscript.c   |    2 +-
 dlls/mshtml/htmlselect.c   |    2 +-
 dlls/mshtml/htmltable.c    |    2 +-
 dlls/mshtml/htmltextarea.c |    2 +-
 10 files changed, 10 insertions(+), 11 deletions(-)

diff --git a/dlls/mshtml/htmlanchor.c b/dlls/mshtml/htmlanchor.c
index d404925..8663291 100644
--- a/dlls/mshtml/htmlanchor.c
+++ b/dlls/mshtml/htmlanchor.c
@@ -481,7 +481,7 @@ static const NodeImplVtbl HTMLAnchorElementImplVtbl = {
 
 HTMLElement *HTMLAnchorElement_Create(nsIDOMHTMLElement *nselem)
 {
-    HTMLAnchorElement *ret = heap_alloc(sizeof(HTMLAnchorElement));
+    HTMLAnchorElement *ret = heap_alloc_zero(sizeof(HTMLAnchorElement));
 
     HTMLElement_Init(&ret->element);
 
diff --git a/dlls/mshtml/htmlbody.c b/dlls/mshtml/htmlbody.c
index 2ca3f28..8e1f70c 100644
--- a/dlls/mshtml/htmlbody.c
+++ b/dlls/mshtml/htmlbody.c
@@ -598,7 +598,7 @@ static const NodeImplVtbl HTMLBodyElementImplVtbl = {
 
 HTMLElement *HTMLBodyElement_Create(nsIDOMHTMLElement *nselem)
 {
-    HTMLBodyElement *ret = heap_alloc(sizeof(HTMLBodyElement));
+    HTMLBodyElement *ret = heap_alloc_zero(sizeof(HTMLBodyElement));
     nsresult nsres;
 
     TRACE("(%p)->(%p)\n", ret, nselem);
diff --git a/dlls/mshtml/htmlelem.c b/dlls/mshtml/htmlelem.c
index 6dab3a1..8777870 100644
--- a/dlls/mshtml/htmlelem.c
+++ b/dlls/mshtml/htmlelem.c
@@ -1336,7 +1336,7 @@ HTMLElement *HTMLElement_Create(nsIDOMNode *nsnode)
         ret = HTMLTextAreaElement_Create(nselem);
 
     if(!ret) {
-        ret = heap_alloc(sizeof(HTMLElement));
+        ret = heap_alloc_zero(sizeof(HTMLElement));
         HTMLElement_Init(ret);
     }
 
diff --git a/dlls/mshtml/htmlinput.c b/dlls/mshtml/htmlinput.c
index 9c390c8..e580bb6 100644
--- a/dlls/mshtml/htmlinput.c
+++ b/dlls/mshtml/htmlinput.c
@@ -1055,7 +1055,7 @@ static const NodeImplVtbl HTMLInputElementImplVtbl = {
 
 HTMLElement *HTMLInputElement_Create(nsIDOMHTMLElement *nselem)
 {
-    HTMLInputElement *ret = heap_alloc(sizeof(HTMLInputElement));
+    HTMLInputElement *ret = heap_alloc_zero(sizeof(HTMLInputElement));
     nsresult nsres;
 
     HTMLElement_Init(&ret->element);
diff --git a/dlls/mshtml/htmlnode.c b/dlls/mshtml/htmlnode.c
index 64cabe4..f009411 100644
--- a/dlls/mshtml/htmlnode.c
+++ b/dlls/mshtml/htmlnode.c
@@ -352,14 +352,13 @@ static HTMLDOMNode *create_node(HTMLDocument *doc, nsIDOMNode *nsnode)
         ret = &HTMLElement_Create(nsnode)->node;
         break;
     default:
-        ret = heap_alloc(sizeof(HTMLDOMNode));
+        ret = heap_alloc_zero(sizeof(HTMLDOMNode));
         ret->vtbl = &HTMLDOMNodeImplVtbl;
     }
 
     ret->lpHTMLDOMNodeVtbl = &HTMLDOMNodeVtbl;
     ret->ref = 1;
     ret->doc = doc;
-    ret->event_target = NULL;
 
     nsIDOMNode_AddRef(nsnode);
     ret->nsnode = nsnode;
diff --git a/dlls/mshtml/htmloption.c b/dlls/mshtml/htmloption.c
index 20a35ae..7252dde 100644
--- a/dlls/mshtml/htmloption.c
+++ b/dlls/mshtml/htmloption.c
@@ -333,7 +333,7 @@ static const NodeImplVtbl HTMLOptionElementImplVtbl = {
 
 HTMLElement *HTMLOptionElement_Create(nsIDOMHTMLElement *nselem)
 {
-    HTMLOptionElement *ret = heap_alloc(sizeof(HTMLOptionElement));
+    HTMLOptionElement *ret = heap_alloc_zero(sizeof(HTMLOptionElement));
     nsresult nsres;
 
     HTMLElement_Init(&ret->element);
diff --git a/dlls/mshtml/htmlscript.c b/dlls/mshtml/htmlscript.c
index 6c49af5..36512ad 100644
--- a/dlls/mshtml/htmlscript.c
+++ b/dlls/mshtml/htmlscript.c
@@ -288,7 +288,7 @@ static const NodeImplVtbl HTMLScriptElementImplVtbl = {
 
 HTMLElement *HTMLScriptElement_Create(nsIDOMHTMLElement *nselem)
 {
-    HTMLScriptElement *ret = heap_alloc(sizeof(HTMLScriptElement));
+    HTMLScriptElement *ret = heap_alloc_zero(sizeof(HTMLScriptElement));
     nsresult nsres;
 
     HTMLElement_Init(&ret->element);
diff --git a/dlls/mshtml/htmlselect.c b/dlls/mshtml/htmlselect.c
index 3718e8a..03fcb8f 100644
--- a/dlls/mshtml/htmlselect.c
+++ b/dlls/mshtml/htmlselect.c
@@ -422,7 +422,7 @@ static const NodeImplVtbl HTMLSelectElementImplVtbl = {
 
 HTMLElement *HTMLSelectElement_Create(nsIDOMHTMLElement *nselem)
 {
-    HTMLSelectElement *ret = heap_alloc(sizeof(HTMLSelectElement));
+    HTMLSelectElement *ret = heap_alloc_zero(sizeof(HTMLSelectElement));
     nsresult nsres;
 
     HTMLElement_Init(&ret->element);
diff --git a/dlls/mshtml/htmltable.c b/dlls/mshtml/htmltable.c
index 66d55d0..88f6e75 100644
--- a/dlls/mshtml/htmltable.c
+++ b/dlls/mshtml/htmltable.c
@@ -546,7 +546,7 @@ static const NodeImplVtbl HTMLTableImplVtbl = {
 
 HTMLElement *HTMLTable_Create(nsIDOMHTMLElement *nselem)
 {
-    HTMLTable *ret = heap_alloc(sizeof(HTMLTable));
+    HTMLTable *ret = heap_alloc_zero(sizeof(HTMLTable));
 
     HTMLElement_Init(&ret->element);
 
diff --git a/dlls/mshtml/htmltextarea.c b/dlls/mshtml/htmltextarea.c
index 64245e7..6e94174 100644
--- a/dlls/mshtml/htmltextarea.c
+++ b/dlls/mshtml/htmltextarea.c
@@ -402,7 +402,7 @@ static const NodeImplVtbl HTMLTextAreaElementImplVtbl = {
 
 HTMLElement *HTMLTextAreaElement_Create(nsIDOMHTMLElement *nselem)
 {
-    HTMLTextAreaElement *ret = heap_alloc(sizeof(HTMLTextAreaElement));
+    HTMLTextAreaElement *ret = heap_alloc_zero(sizeof(HTMLTextAreaElement));
     nsresult nsres;
 
     HTMLElement_Init(&ret->element);




More information about the wine-cvs mailing list