Christian Costa : quartz: Avoid leaking penummt and mt on error.

Alexandre Julliard julliard at winehq.org
Mon Dec 1 07:34:22 CST 2008


Module: wine
Branch: master
Commit: 14485c365b9a624fb3785ff027adc6c5596719a0
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=14485c365b9a624fb3785ff027adc6c5596719a0

Author: Christian Costa <titan.costa at wanadoo.fr>
Date:   Sun Nov 30 15:52:58 2008 +0100

quartz: Avoid leaking penummt and mt on error.

---

 dlls/quartz/filtergraph.c |   11 ++++++-----
 1 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/dlls/quartz/filtergraph.c b/dlls/quartz/filtergraph.c
index ff185ce..8480d25 100644
--- a/dlls/quartz/filtergraph.c
+++ b/dlls/quartz/filtergraph.c
@@ -867,8 +867,8 @@ static HRESULT WINAPI FilterGraph2_Connect(IFilterGraph2 *iface, IPin *ppinOut,
 {
     ICOM_THIS_MULTI(IFilterGraphImpl, IFilterGraph2_vtbl, iface);
     HRESULT hr;
-    AM_MEDIA_TYPE* mt;
-    IEnumMediaTypes* penummt;
+    AM_MEDIA_TYPE* mt = NULL;
+    IEnumMediaTypes* penummt = NULL;
     ULONG nbmt;
     IEnumPins* penumpins;
     IEnumMoniker* pEnumMoniker;
@@ -1095,10 +1095,11 @@ error:
         }
     }
 
-    IEnumMediaTypes_Release(penummt);
-    DeleteMediaType(mt);
-
 out:
+    if (penummt)
+        IEnumMediaTypes_Release(penummt);
+    if (mt)
+        DeleteMediaType(mt);
     --This->recursioncount;
     LeaveCriticalSection(&This->cs);
     TRACE("--> %08x\n", hr);




More information about the wine-cvs mailing list