Michael Karcher : msxml3: Quiet noisy fixmes.

Alexandre Julliard julliard at winehq.org
Mon Dec 1 07:34:25 CST 2008


Module: wine
Branch: master
Commit: a6594da463e338043a2350739be4715011472fa3
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=a6594da463e338043a2350739be4715011472fa3

Author: Michael Karcher <wine at mkarcher.dialup.fu-berlin.de>
Date:   Sat Nov 29 10:51:44 2008 +0100

msxml3: Quiet noisy fixmes.

The FIXME messages for unknown interfaces should not be emitted for
interfaces that should not get implemented. Origin 8 spams you with
these messsages.

---

 dlls/msxml3/cdata.c |    6 ++++++
 dlls/msxml3/text.c  |    7 +++++++
 2 files changed, 13 insertions(+), 0 deletions(-)

diff --git a/dlls/msxml3/cdata.c b/dlls/msxml3/cdata.c
index aa59ec3..dc7399b 100644
--- a/dlls/msxml3/cdata.c
+++ b/dlls/msxml3/cdata.c
@@ -69,6 +69,12 @@ static HRESULT WINAPI domcdata_QueryInterface(
     {
         return IUnknown_QueryInterface(This->node_unk, riid, ppvObject);
     }
+    else if ( IsEqualGUID( riid, &IID_IXMLDOMText ) ||
+              IsEqualGUID( riid, &IID_IXMLDOMElement ) )
+    {
+        TRACE("Unsupported interface\n");
+        return E_NOINTERFACE;
+    }
     else
     {
         FIXME("Unsupported interface %s\n", debugstr_guid(riid));
diff --git a/dlls/msxml3/text.c b/dlls/msxml3/text.c
index f8e1fc4..c39fd07 100644
--- a/dlls/msxml3/text.c
+++ b/dlls/msxml3/text.c
@@ -70,6 +70,13 @@ static HRESULT WINAPI domtext_QueryInterface(
     {
         return IUnknown_QueryInterface(This->node_unk, riid, ppvObject);
     }
+    else if ( IsEqualGUID( riid, &IID_IXMLDOMElement ) ||
+              IsEqualGUID( riid, &IID_IXMLDOMCDATASection ) )
+    {
+        /* IXMLDOMText is known to be correct in not implementing these */
+        TRACE("Unsupported interface\n");
+        return E_NOINTERFACE;
+    }
     else
     {
         FIXME("Unsupported interface %s\n", debugstr_guid(riid));




More information about the wine-cvs mailing list