Kai Blin : kernel32/tests: logfile can be NULL, avoid dereferencing it ( Coverity).

Alexandre Julliard julliard at winehq.org
Mon Dec 1 07:34:27 CST 2008


Module: wine
Branch: master
Commit: a30724304cda3fa7eff8077057aa5d255b42d5ce
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=a30724304cda3fa7eff8077057aa5d255b42d5ce

Author: Kai Blin <kai.blin at gmail.com>
Date:   Mon Dec  1 14:03:55 2008 +0100

kernel32/tests: logfile can be NULL, avoid dereferencing it (Coverity).

---

 dlls/kernel32/tests/debugger.c |   11 +++++++++--
 1 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/dlls/kernel32/tests/debugger.c b/dlls/kernel32/tests/debugger.c
index 0b943f2..014f390 100644
--- a/dlls/kernel32/tests/debugger.c
+++ b/dlls/kernel32/tests/debugger.c
@@ -158,7 +158,11 @@ static void doDebugger(int argc, char** argv)
     else
         blackbox.debug_rc=TRUE;
 
-    get_events(logfile, &start_event, &done_event);
+    if (logfile)
+    {
+        get_events(logfile, &start_event, &done_event);
+    }
+
     if (strstr(myARGV[2], "order"))
     {
         trace("debugger: waiting for the start signal...\n");
@@ -185,7 +189,10 @@ static void doDebugger(int argc, char** argv)
     else
         blackbox.detach_rc=TRUE;
 
-    save_blackbox(logfile, &blackbox, sizeof(blackbox));
+    if (logfile)
+    {
+        save_blackbox(logfile, &blackbox, sizeof(blackbox));
+    }
     trace("debugger: done debugging...\n");
     SetEvent(done_event);
 




More information about the wine-cvs mailing list