Vincent Povirk : advpack/tests: Fix string format warning.

Alexandre Julliard julliard at winehq.org
Fri Dec 5 07:42:51 CST 2008


Module: wine
Branch: master
Commit: e4271d8736fc7687c8d01021947455b0763a8673
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=e4271d8736fc7687c8d01021947455b0763a8673

Author: Vincent Povirk <madewokherd+d41d at gmail.com>
Date:   Thu Dec  4 21:26:48 2008 -0600

advpack/tests: Fix string format warning.

---

 dlls/advpack/tests/install.c |   21 +++++++--------------
 1 files changed, 7 insertions(+), 14 deletions(-)

diff --git a/dlls/advpack/tests/install.c b/dlls/advpack/tests/install.c
index 854ede6..3b0954f 100644
--- a/dlls/advpack/tests/install.c
+++ b/dlls/advpack/tests/install.c
@@ -55,27 +55,20 @@ static BOOL is_spapi_err(DWORD err)
     return (((err & SPAPI_MASK) ^ SPAPI_PREFIX) == 0);
 }
 
-static void append_str(char **str, const char *data)
-{
-    sprintf(*str, data);
-    *str += strlen(*str);
-}
-
 static void create_inf_file(LPCSTR filename)
 {
-    char data[1024];
-    char *ptr = data;
     DWORD dwNumberOfBytesWritten;
     HANDLE hf = CreateFile(filename, GENERIC_WRITE, 0, NULL,
                            CREATE_ALWAYS, FILE_ATTRIBUTE_NORMAL, NULL);
 
-    append_str(&ptr, "[Version]\n");
-    append_str(&ptr, "Signature=\"$Chicago$\"\n");
-    append_str(&ptr, "AdvancedINF=2.5\n");
-    append_str(&ptr, "[DefaultInstall]\n");
-    append_str(&ptr, "CheckAdminRights=1\n");
+    static const char data[] =
+        "[Version]\n"
+        "Signature=\"$Chicago$\"\n"
+        "AdvancedINF=2.5\n"
+        "[DefaultInstall]\n"
+        "CheckAdminRights=1\n";
 
-    WriteFile(hf, data, ptr - data, &dwNumberOfBytesWritten, NULL);
+    WriteFile(hf, data, sizeof(data) - 1, &dwNumberOfBytesWritten, NULL);
     CloseHandle(hf);
 }
 




More information about the wine-cvs mailing list