Christian Costa : quartz: Turn some fixmes into traces.

Alexandre Julliard julliard at winehq.org
Tue Dec 9 06:24:12 CST 2008


Module: wine
Branch: master
Commit: 480e6970356fb27e745950861bf83524394ecaa8
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=480e6970356fb27e745950861bf83524394ecaa8

Author: Christian Costa <titan.costa at wanadoo.fr>
Date:   Sun Dec  7 12:09:43 2008 +0100

quartz: Turn some fixmes into traces.

---

 dlls/quartz/avisplit.c |   14 ++++++++------
 1 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/dlls/quartz/avisplit.c b/dlls/quartz/avisplit.c
index 513bd88..94d2c9b 100644
--- a/dlls/quartz/avisplit.c
+++ b/dlls/quartz/avisplit.c
@@ -359,8 +359,10 @@ static DWORD WINAPI AVISplitter_thread_reader(LPVOID data)
             AVISplitter_SendEndOfFile(This, streamnumber);
     } while (hr == S_OK);
 
-    FIXME("Thread %u terminated with hr %08x!\n", streamnumber, hr);
-
+    if (hr != S_FALSE)
+        FIXME("Thread %u terminated with hr %08x!\n", streamnumber, hr);
+    else
+        TRACE("Thread %u terminated properly\n", streamnumber);
     return hr;
 }
 
@@ -472,7 +474,7 @@ static HRESULT AVISplitter_first_request(LPVOID iface)
         args->This = This;
         args->stream = x;
         This->streams[x].thread = CreateThread(NULL, 0, AVISplitter_thread_reader, args, 0, &tid);
-        FIXME("Created stream %u thread 0x%08x\n", x, tid);
+        TRACE("Created stream %u thread 0x%08x\n", x, tid);
     }
 
     if (FAILED(hr))
@@ -491,7 +493,7 @@ static HRESULT AVISplitter_done_process(LPVOID iface)
     {
         StreamData *stream = This->streams + x;
 
-        FIXME("Waiting for %u to terminate\n", x);
+        TRACE("Waiting for %u to terminate\n", x);
         /* Make the thread return first */
         SetEvent(stream->packet_queued);
         assert(WaitForSingleObject(stream->thread, 100000) != WAIT_TIMEOUT);
@@ -504,7 +506,7 @@ static HRESULT AVISplitter_done_process(LPVOID iface)
 
         ResetEvent(stream->packet_queued);
     }
-    FIXME("All threads are now terminated\n");
+    TRACE("All threads are now terminated\n");
 
     return S_OK;
 }
@@ -1194,7 +1196,7 @@ static HRESULT AVISplitter_Flush(LPVOID iface)
     AVISplitterImpl *This = (AVISplitterImpl*)iface;
     DWORD x;
 
-    ERR("(%p)->()\n", This);
+    TRACE("(%p)->()\n", This);
 
     for (x = 0; x < This->Parser.cStreams; ++x)
     {




More information about the wine-cvs mailing list