Alistair Leslie-Hughes : msxml3: Implement IXMLDOMAttribute name property.
Alexandre Julliard
julliard at winehq.org
Sat Feb 16 09:57:36 CST 2008
Module: wine
Branch: master
Commit: e9063b77769be6c2ed5bff2d3da17741d898459d
URL: http://source.winehq.org/git/wine.git/?a=commit;h=e9063b77769be6c2ed5bff2d3da17741d898459d
Author: Alistair Leslie-Hughes <leslie_alistair at hotmail.com>
Date: Sat Feb 16 22:31:01 2008 +1100
msxml3: Implement IXMLDOMAttribute name property.
---
dlls/msxml3/attribute.c | 5 +++--
dlls/msxml3/tests/domdoc.c | 12 ++++++++++++
2 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/dlls/msxml3/attribute.c b/dlls/msxml3/attribute.c
index 805bafe..49c39fe 100644
--- a/dlls/msxml3/attribute.c
+++ b/dlls/msxml3/attribute.c
@@ -433,8 +433,9 @@ static HRESULT WINAPI domattr_get_name(
IXMLDOMAttribute *iface,
BSTR *p)
{
- FIXME("\n");
- return E_NOTIMPL;
+ /* name property returns the same value as nodeName */
+ domattr *This = impl_from_IXMLDOMAttribute( iface );
+ return IXMLDOMNode_get_nodeName( This->node, p );
}
static HRESULT WINAPI domattr_get_value(
diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c
index 424de18..2401878 100644
--- a/dlls/msxml3/tests/domdoc.c
+++ b/dlls/msxml3/tests/domdoc.c
@@ -2128,6 +2128,18 @@ static void test_xmlTypes(void)
ok( !lstrcmpW( str, _bstr_("attribute") ), "incorrect nodeTypeString string\n");
SysFreeString(str);
+ /* test nodeName */
+ hr = IXMLDOMAttribute_get_nodeName(pAttrubute, &str);
+ ok(hr == S_OK, "ret %08x\n", hr );
+ ok( !lstrcmpW( str, szAttribute ), "incorrect nodeName string\n");
+ SysFreeString(str);
+
+ /* test name property */
+ hr = IXMLDOMAttribute_get_name(pAttrubute, &str);
+ ok(hr == S_OK, "ret %08x\n", hr );
+ ok( !lstrcmpW( str, szAttribute ), "incorrect name string\n");
+ SysFreeString(str);
+
hr = IXMLDOMAttribute_get_xml(pAttrubute, &str);
ok(hr == S_OK, "ret %08x\n", hr );
ok( !lstrcmpW( str, szAttributeXML ), "incorrect attribute xml\n");
More information about the wine-cvs
mailing list