Alistair Leslie-Hughes : msxml3: Implement IXMLDOMComment_get_nodeValue.

Alexandre Julliard julliard at winehq.org
Thu Feb 28 06:21:49 CST 2008


Module: wine
Branch: master
Commit: a1f5fef880382642fe11b135d42d09e2e2ed2b6e
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=a1f5fef880382642fe11b135d42d09e2e2ed2b6e

Author: Alistair Leslie-Hughes <leslie_alistair at hotmail.com>
Date:   Thu Feb 28 21:03:59 2008 +1100

msxml3: Implement IXMLDOMComment_get_nodeValue.

---

 dlls/msxml3/node.c         |    1 +
 dlls/msxml3/tests/domdoc.c |    7 +++++++
 2 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/dlls/msxml3/node.c b/dlls/msxml3/node.c
index 23734ab..676209e 100644
--- a/dlls/msxml3/node.c
+++ b/dlls/msxml3/node.c
@@ -251,6 +251,7 @@ static HRESULT WINAPI xmlnode_get_nodeValue(
 
     switch ( This->node->type )
     {
+    case XML_COMMENT_NODE:
     case XML_PI_NODE:
     case XML_ATTRIBUTE_NODE:
       {
diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c
index efaae79..2569647 100644
--- a/dlls/msxml3/tests/domdoc.c
+++ b/dlls/msxml3/tests/domdoc.c
@@ -2098,6 +2098,13 @@ static void test_xmlTypes(void)
                 hr = IXMLDOMComment_put_data(pComment, _bstr_("This &is a ; test <>\\"));
                 ok(hr == S_OK, "ret %08x\n", hr );
 
+                /* get data Tests */
+                hr = IXMLDOMComment_get_nodeValue(pComment, &v);
+                ok(hr == S_OK, "ret %08x\n", hr );
+                ok( V_VT(&v) == VT_BSTR, "incorrect dataType type\n");
+                ok( !lstrcmpW( V_BSTR(&v), _bstr_("This &is a ; test <>\\") ), "incorrect get_nodeValue string\n");
+                VariantClear(&v);
+
                 /* Confirm XML text is good */
                 hr = IXMLDOMComment_get_xml(pComment, &str);
                 ok(hr == S_OK, "ret %08x\n", hr );




More information about the wine-cvs mailing list