Eric Pouech : msvcrt: symbol undecoration: Corrected handling of non static member function modifiers.
Alexandre Julliard
julliard at winehq.org
Tue Jan 22 06:01:50 CST 2008
Module: wine
Branch: master
Commit: 3db08321f43e305988e4536022b8bdc2da4a80ee
URL: http://source.winehq.org/git/wine.git/?a=commit;h=3db08321f43e305988e4536022b8bdc2da4a80ee
Author: Eric Pouech <eric.pouech at orange.fr>
Date: Mon Jan 21 22:05:52 2008 +0100
msvcrt: symbol undecoration: Corrected handling of non static member function modifiers.
---
dlls/msvcrt/undname.c | 19 +++++++++++--------
1 files changed, 11 insertions(+), 8 deletions(-)
diff --git a/dlls/msvcrt/undname.c b/dlls/msvcrt/undname.c
index d1da19b..f83d998 100644
--- a/dlls/msvcrt/undname.c
+++ b/dlls/msvcrt/undname.c
@@ -971,6 +971,7 @@ done:
*/
static BOOL handle_method(struct parsed_symbol* sym, BOOL cast_op)
{
+ char accmem;
const char* access = NULL;
const char* member_type = NULL;
struct datatype_t ct_ret;
@@ -1012,9 +1013,12 @@ static BOOL handle_method(struct parsed_symbol* sym, BOOL cast_op)
* 'Z'
*/
+ accmem = *sym->current++;
+ if (accmem < 'A' || accmem > 'Z') goto done;
+
if (!(sym->flags & UNDNAME_NO_ACCESS_SPECIFIERS))
{
- switch ((*sym->current - 'A') / 8)
+ switch ((accmem - 'A') / 8)
{
case 0: access = "private: "; break;
case 1: access = "protected: "; break;
@@ -1023,9 +1027,9 @@ static BOOL handle_method(struct parsed_symbol* sym, BOOL cast_op)
}
if (!(sym->flags & UNDNAME_NO_MEMBER_TYPE))
{
- if (*sym->current >= 'A' && *sym->current <= 'X')
+ if (accmem <= 'X')
{
- switch ((*sym->current - 'A') % 8)
+ switch ((accmem - 'A') % 8)
{
case 2: case 3: member_type = "static "; break;
case 4: case 5: member_type = "virtual "; break;
@@ -1034,17 +1038,16 @@ static BOOL handle_method(struct parsed_symbol* sym, BOOL cast_op)
}
}
- if (*sym->current >= 'A' && *sym->current <= 'X')
+ if (accmem <= 'X')
{
- if (!((*sym->current - 'A') & 2))
+ if (((accmem - 'A') % 8) != 2 && ((accmem - 'A') % 8) != 3)
{
/* Implicit 'this' pointer */
/* If there is an implicit this pointer, const modifier follows */
- if (!get_modifier(*++sym->current, &modifier)) goto done;
+ if (!get_modifier(*sym->current, &modifier)) goto done;
+ sym->current++;
}
}
- else if (*sym->current < 'A' || *sym->current > 'Z') goto done;
- sym->current++;
name = get_class_string(sym, 0);
More information about the wine-cvs
mailing list