Alexander Nicolaysen Sørnes : Don' t pass titles as part of delete links

Chris Morgan cmorgan at winehq.org
Tue Jun 3 18:26:09 CDT 2008


Module: appdb
Branch: master
Commit: 6bd6839995b1cbd7e4c42f0a3786495804454ff3
URL:    http://source.winehq.org/git/appdb.git/?a=commit;h=6bd6839995b1cbd7e4c42f0a3786495804454ff3

Author: Alexander Nicolaysen Sørnes <alex at thehandofagony.com>
Date:   Tue Jun  3 12:19:17 2008 +0200

Don't pass titles as part of delete links

---

 include/application.php |    4 +++-
 include/version.php     |    4 +++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/include/application.php b/include/application.php
index b8bc19c..d663ed8 100644
--- a/include/application.php
+++ b/include/application.php
@@ -719,6 +719,8 @@ class Application {
     {
         switch($sAction)
         {
+            case 'delete':
+                return 'Delete '.$this->sName;
             case "view":
                 return $this->sName;
 
@@ -821,7 +823,7 @@ class Application {
             }
             if($_SESSION['current']->hasPriv("admin"))
             {
-                $url = BASE."objectManager.php?sClass=application&amp;bIsQueue=false&amp;sAction=delete&amp;sTitle=Delete%20".$this->sName."&amp;iId=".$this->iAppId;
+                $url = BASE."objectManager.php?sClass=application&amp;bIsQueue=false&amp;sAction=delete&amp;iId=".$this->iAppId;
                 echo "        <form method=\"post\" name=\"sEdit\" action=\"javascript:self.location = '".$url."'\"><input type=\"submit\" value=\"Delete App\" class=\"button\"></form>";
                 echo '        <form method="post" name="sEdit" action="admin/editBundle.php"><input type="hidden" name="iBundleId" value="'.$this->iAppId.'"><input type="submit" value="Edit Bundle" class="button"></form>';
             }
diff --git a/include/version.php b/include/version.php
index 674c180..04affed 100644
--- a/include/version.php
+++ b/include/version.php
@@ -745,6 +745,8 @@ class version {
     {
         switch($sAction)
         {
+            case 'delete':
+                return 'Delete '.version::fullName($this->iVersionId);
             case "view":
                 return version::fullName($this->iVersionId);
 
@@ -971,7 +973,7 @@ class version {
             echo "\t".'<input type="hidden" name="iVersionId" value="'.$this->iVersionId.'">'."\n";
             echo "\t".'<input type=submit value="Edit Version" class="button">'."\n";
             echo '</form>'."\n";
-            $url = BASE."objectManager.php?sClass=version&amp;sAction=delete&amp;bQueued=false&amp;sTitle=Delete%20".version::fullName($this->iVersionId)."&amp;iId=".$this->iVersionId;
+            $url = BASE."objectManager.php?sClass=version&amp;sAction=delete&amp;bQueued=false&amp;iId=".$this->iVersionId;
             echo "<form method=\"post\" name=\"sDelete\" action=\"javascript:self.location = '".$url."'\">\n";
             echo "\t".'<input type=submit value="Delete Version" class="button">'."\n";
             echo '</form>'."\n";




More information about the wine-cvs mailing list