Andrew Talbot : urlmon: Assign to structs instead of using memcpy.

Alexandre Julliard julliard at winehq.org
Wed Mar 19 07:28:14 CDT 2008


Module: wine
Branch: master
Commit: dbe7718e2b231aed539079b20594094c75461262
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=dbe7718e2b231aed539079b20594094c75461262

Author: Andrew Talbot <andrew.talbot at talbotville.com>
Date:   Tue Mar 18 21:42:20 2008 +0000

urlmon: Assign to structs instead of using memcpy.

---

 dlls/urlmon/binding.c     |    4 ++--
 dlls/urlmon/urlmon_main.c |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/dlls/urlmon/binding.c b/dlls/urlmon/binding.c
index c647230..47b521c 100644
--- a/dlls/urlmon/binding.c
+++ b/dlls/urlmon/binding.c
@@ -1083,7 +1083,7 @@ static HRESULT WINAPI InternetProtocolSink_Switch(IInternetProtocolSink *iface,
     TRACE("(%p)->(%p)\n", This, pProtocolData);
 
     task = heap_alloc(sizeof(switch_task_t));
-    memcpy(&task->data, pProtocolData, sizeof(PROTOCOLDATA));
+    task->data = *pProtocolData;
 
     push_task(This, &task->header, switch_proc);
 
@@ -1382,7 +1382,7 @@ static HRESULT WINAPI InternetBindInfo_GetBindInfo(IInternetBindInfo *iface,
 
     *grfBINDF = This->bindf;
 
-    memcpy(pbindinfo, &This->bindinfo, sizeof(BINDINFO));
+    *pbindinfo = This->bindinfo;
 
     if(pbindinfo->szExtraInfo || pbindinfo->szCustomVerb)
         FIXME("copy strings\n");
diff --git a/dlls/urlmon/urlmon_main.c b/dlls/urlmon/urlmon_main.c
index 7d56062..bc3de93 100644
--- a/dlls/urlmon/urlmon_main.c
+++ b/dlls/urlmon/urlmon_main.c
@@ -398,7 +398,7 @@ HRESULT WINAPI CopyStgMedium(const STGMEDIUM *src, STGMEDIUM *dst)
     if(!src || !dst)
         return E_POINTER;
 
-    memcpy(dst, src, sizeof(STGMEDIUM));
+    *dst = *src;
 
     switch(dst->tymed) {
     case TYMED_NULL:




More information about the wine-cvs mailing list