Rob Shearman : wininet: Compare HRESULT values explicitly against S_OK instead of using an implicit ! = 0 comparison.

Alexandre Julliard julliard at winehq.org
Wed Oct 1 14:09:41 CDT 2008


Module: wine
Branch: master
Commit: d31ce9ae37653cc199ba7bd017639a3d864fab5d
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=d31ce9ae37653cc199ba7bd017639a3d864fab5d

Author: Rob Shearman <robertshearman at gmail.com>
Date:   Wed Oct  1 11:20:49 2008 +0100

wininet: Compare HRESULT values explicitly against S_OK instead of using an implicit != 0 comparison.

---

 dlls/wininet/http.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/wininet/http.c b/dlls/wininet/http.c
index 7cb3961..c41aca6 100644
--- a/dlls/wininet/http.c
+++ b/dlls/wininet/http.c
@@ -1948,7 +1948,7 @@ HINTERNET WINAPI HTTP_HttpOpenRequestW(LPWININETHTTPSESSIONW lpwhs,
         lpwhr->lpszPath = HeapAlloc(GetProcessHeap(), 0, len*sizeof(WCHAR));
         rc = UrlEscapeW(lpszObjectName, lpwhr->lpszPath, &len,
                    URL_ESCAPE_SPACES_ONLY);
-        if (rc)
+        if (rc != S_OK)
         {
             ERR("Unable to escape string!(%s) (%d)\n",debugstr_w(lpszObjectName),rc);
             strcpyW(lpwhr->lpszPath,lpszObjectName);
@@ -3045,7 +3045,7 @@ static BOOL HTTP_HandleRedirect(LPWININETHTTPREQW lpwhr, LPCWSTR lpszUrl)
         lpwhr->lpszPath = HeapAlloc(GetProcessHeap(), 0, needed*sizeof(WCHAR));
         rc = UrlEscapeW(path, lpwhr->lpszPath, &needed,
                         URL_ESCAPE_SPACES_ONLY);
-        if (rc)
+        if (rc != S_OK)
         {
             ERR("Unable to escape string!(%s) (%d)\n",debugstr_w(path),rc);
             strcpyW(lpwhr->lpszPath,path);




More information about the wine-cvs mailing list