Michael Stefaniuc : quartz: Use the right FAILED/ SUCCEEDED macro instead of negating the opposite.

Alexandre Julliard julliard at winehq.org
Wed Oct 8 08:32:58 CDT 2008


Module: wine
Branch: master
Commit: 56c6f7670b3fd4d79f4511752b283b5dff5335ba
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=56c6f7670b3fd4d79f4511752b283b5dff5335ba

Author: Michael Stefaniuc <mstefani at redhat.de>
Date:   Wed Oct  8 01:33:43 2008 +0200

quartz: Use the right FAILED/SUCCEEDED macro instead of negating the opposite.

---

 dlls/quartz/filtergraph.c  |    4 ++--
 dlls/quartz/filtermapper.c |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/dlls/quartz/filtergraph.c b/dlls/quartz/filtergraph.c
index c9e4e56..5837a47 100644
--- a/dlls/quartz/filtergraph.c
+++ b/dlls/quartz/filtergraph.c
@@ -1367,7 +1367,7 @@ error:
                 IFilterGraph2_RemoveFilter(iface, pfilter);
                 IBaseFilter_Release(pfilter);
             }
-            if (!FAILED(hr)) DebugBreak();
+            if (SUCCEEDED(hr)) DebugBreak();
         }
 
         IEnumMoniker_Release(pEnumMoniker);
@@ -2140,7 +2140,7 @@ static HRESULT all_renderers_seek(IFilterGraphImpl *This, fnFoundSeek FoundSeek,
             IMediaSeeking_Release(seek);
             if (hr_return != E_NOTIMPL)
                 allnotimpl = FALSE;
-            if (hr_return == S_OK || (FAILED(hr) && hr != E_NOTIMPL && !FAILED(hr_return)))
+            if (hr_return == S_OK || (FAILED(hr) && hr != E_NOTIMPL && SUCCEEDED(hr_return)))
                 hr_return = hr;
         }
     }
diff --git a/dlls/quartz/filtermapper.c b/dlls/quartz/filtermapper.c
index a085b0a..5732755 100644
--- a/dlls/quartz/filtermapper.c
+++ b/dlls/quartz/filtermapper.c
@@ -1297,7 +1297,7 @@ static HRESULT WINAPI FilterMapper_EnumMatchingFilters(
                                        NULL,
                                        &GUID_NULL);
 
-    if (!SUCCEEDED(hr))
+    if (FAILED(hr))
         return hr;
     
     while(IEnumMoniker_Next(ppEnumMoniker, 1, &IMon, &nb) == S_OK)




More information about the wine-cvs mailing list