Michael Stefaniuc : qcap: Use the right FAILED/ SUCCEEDED macro instead of negating the opposite.

Alexandre Julliard julliard at winehq.org
Wed Oct 8 08:33:06 CDT 2008


Module: wine
Branch: master
Commit: 2f6df7c2a5d86a1e1c7f5da5048ae96b6f3d61cf
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=2f6df7c2a5d86a1e1c7f5da5048ae96b6f3d61cf

Author: Michael Stefaniuc <mstefani at redhat.de>
Date:   Wed Oct  8 01:36:01 2008 +0200

qcap: Use the right FAILED/SUCCEEDED macro instead of negating the opposite.

---

 dlls/qcap/qcap_main.c  |    2 +-
 dlls/qcap/vfwcapture.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/qcap/qcap_main.c b/dlls/qcap/qcap_main.c
index e5c9e3b..8549f42 100644
--- a/dlls/qcap/qcap_main.c
+++ b/dlls/qcap/qcap_main.c
@@ -265,7 +265,7 @@ static HRESULT WINAPI DSCF_CreateInstance(LPCLASSFACTORY iface, LPUNKNOWN pOuter
     if (!punk)
     {
         /* No object created, update error if it isn't done already and return */
-        if (!FAILED(hres))
+        if (SUCCEEDED(hres))
             hres = E_OUTOFMEMORY;
     return hres;
     }
diff --git a/dlls/qcap/vfwcapture.c b/dlls/qcap/vfwcapture.c
index 738e1d2..cfb9487 100644
--- a/dlls/qcap/vfwcapture.c
+++ b/dlls/qcap/vfwcapture.c
@@ -115,7 +115,7 @@ IUnknown * WINAPI QCAP_createVFWCaptureFilter(IUnknown *pUnkOuter, HRESULT *phr)
     pVfwCapture->csFilter.DebugInfo->Spare[0] = (DWORD_PTR)(__FILE__ ": VfwCapture.csFilter");
     hr = VfwPin_Construct((IBaseFilter *)&pVfwCapture->lpVtbl,
                    &pVfwCapture->csFilter, &pVfwCapture->pOutputPin);
-    if (!SUCCEEDED(hr))
+    if (FAILED(hr))
     {
         CoTaskMemFree(pVfwCapture);
         return NULL;




More information about the wine-cvs mailing list