Jacek Caban : mshtml: Don't fail in IHTMLDOMNode:: appendChild if AppendChild failed.
Alexandre Julliard
julliard at winehq.org
Tue Oct 14 08:29:34 CDT 2008
Module: wine
Branch: master
Commit: 7c8cdd519b3a471992c2dcc68ce458c4563d2a5b
URL: http://source.winehq.org/git/wine.git/?a=commit;h=7c8cdd519b3a471992c2dcc68ce458c4563d2a5b
Author: Jacek Caban <jacek at codeweavers.com>
Date: Mon Oct 13 14:51:04 2008 -0500
mshtml: Don't fail in IHTMLDOMNode::appendChild if AppendChild failed.
---
dlls/mshtml/htmlnode.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/dlls/mshtml/htmlnode.c b/dlls/mshtml/htmlnode.c
index e102951..bee0376 100644
--- a/dlls/mshtml/htmlnode.c
+++ b/dlls/mshtml/htmlnode.c
@@ -512,6 +512,7 @@ static HRESULT WINAPI HTMLDOMNode_removeChild(IHTMLDOMNode *iface, IHTMLDOMNode
/* FIXME: Make sure that node != newChild */
*node = HTMLDOMNODE(get_node(This->doc, nsnode, TRUE));
+ nsIDOMNode_Release(nsnode);
IHTMLDOMNode_AddRef(*node);
return S_OK;
}
@@ -572,8 +573,8 @@ static HRESULT WINAPI HTMLDOMNode_appendChild(IHTMLDOMNode *iface, IHTMLDOMNode
nsres = nsIDOMNode_AppendChild(This->nsnode, node_obj->nsnode, &nsnode);
if(NS_FAILED(nsres)) {
- ERR("AppendChild failed: %08x\n", nsres);
- return E_FAIL;
+ WARN("AppendChild failed: %08x\n", nsres);
+ nsnode = node_obj->nsnode;
}
/* FIXME: Make sure that node != newChild */
More information about the wine-cvs
mailing list