Rob Shearman : shell32: Free the correct pointer in XDG_UserDirLookup.

Alexandre Julliard julliard at winehq.org
Thu Oct 16 09:34:17 CDT 2008


Module: wine
Branch: stable
Commit: 7d44bdc1b84170cc37e5144f74a79a8114ed170a
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=7d44bdc1b84170cc37e5144f74a79a8114ed170a

Author: Rob Shearman <robertshearman at gmail.com>
Date:   Thu Jun 19 07:51:26 2008 +0100

shell32: Free the correct pointer in XDG_UserDirLookup.

out_ptr is a stack variable. *out_ptr is heap allocated and is what
was meant to be freed.
(cherry picked from commit ff838008393cf57431013aac84d919e5c18c75d5)

---

 dlls/shell32/xdg.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/dlls/shell32/xdg.c b/dlls/shell32/xdg.c
index c578b90..6eb13a2 100644
--- a/dlls/shell32/xdg.c
+++ b/dlls/shell32/xdg.c
@@ -963,7 +963,7 @@ xdg_user_dir_lookup_error:
     if (FAILED(hr))
     {
         for (i = 0; i < num_dirs; i++) HeapFree(GetProcessHeap(), 0, out[i]);
-        HeapFree(GetProcessHeap(), 0, out_ptr);
+        HeapFree(GetProcessHeap(), 0, *out_ptr);
     }
     return hr;
 }




More information about the wine-cvs mailing list