Alexander Dorofeyev : quartz/tests: Fix potential NULL dereference ( Coverity).

Alexandre Julliard julliard at winehq.org
Wed Sep 10 06:01:42 CDT 2008


Module: wine
Branch: master
Commit: 48865c9064d2459074cf8813e9d72681d4c38fec
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=48865c9064d2459074cf8813e9d72681d4c38fec

Author: Alexander Dorofeyev <alexd4 at inbox.lv>
Date:   Tue Sep  9 20:34:59 2008 +0300

quartz/tests: Fix potential NULL dereference (Coverity).

---

 dlls/quartz/tests/filtergraph.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/dlls/quartz/tests/filtergraph.c b/dlls/quartz/tests/filtergraph.c
index 0867d27..37c1c1f 100644
--- a/dlls/quartz/tests/filtergraph.c
+++ b/dlls/quartz/tests/filtergraph.c
@@ -1122,9 +1122,12 @@ static HRESULT TestFilter_Create(const CLSID* pClsid, const TestFilterPinData *p
 
     error:
 
-    for (i = 0; i < nPins; i++)
+    if (pTestFilter->ppPins)
     {
-        if (pTestFilter->ppPins[i]) IPin_Release(pTestFilter->ppPins[i]);
+        for (i = 0; i < nPins; i++)
+        {
+            if (pTestFilter->ppPins[i]) IPin_Release(pTestFilter->ppPins[i]);
+        }
     }
     CoTaskMemFree(pTestFilter->ppPins);
     DeleteCriticalSection(&pTestFilter->csFilter);




More information about the wine-cvs mailing list